build: Using telescope gen code instead of ts-proto #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And some linting.
ignite scaffold single systemInfo nextId:uint --module checkers --no-message
ignite scaffold map storedGame board turn black red --index index --module checkers --no-message
And unit test.
Signed-off-by: Pranay Valson <[email protected]>
ignite scaffold message createGame black red --module checkers --response gameIndex
And unit tests.
ignite scaffold message playMove gameIndex fromX:uint fromY:uint toX:uint toY:uint --module checkers --response capturedX:int,capturedY:int,winner
And unit tests.
ignite scaffold query canPlayMove gameIndex player fromX:uint fromY:uint toX:uint toY:uint --module checkers --response possible:bool,reason
Submodule contains elements.
Zetazzz
changed the title
6 tasks
|
Thank you. I will not make it part of this code just yet. And when I do, it will not be just a merge of this PR because I have to keep the succession of commits "clean". So I take your work then reorder and squash. |
remove install part from gen-proto-ts in makefile
| @@ -17,5 +17,5 @@ download-cosmos-proto: | |||
| mkdir -p proto/gogoproto | |||
| curl https://raw.githubusercontent.com/cosmos/cosmos-sdk/${cosmos-version}/third_party/proto/gogoproto/gogo.proto -o proto/gogoproto/gogo.proto | |||
|
|
|||
| gen-proto-ts: download-cosmos-proto install-gen-tool | |||
| gen-proto-ts: download-cosmos-proto | |||
There was a problem hiding this comment.
I wonder if download-cosmos-proto will also cause issues if we are not careful with what folders are mapped within Docker.
There was a problem hiding this comment.
I assume that protoDirs is set to ../proto and outPath is set to ../client/src/types/generated in the .telescope.json file, so as long as the working dir is /checkers, I guess there wouldn't be issue when executing npx telescope transpile --config .telescope.json inside scripts folder.
xavierlepretre
force-pushed
the
cosmjs-elements
branch
3 times, most recently
from
9ecf56f to
2073448
Compare
xavierlepretre
force-pushed
the
cosmjs-elements
branch
from
2073448 to
21655f9
Compare
xavierlepretre
force-pushed
the
cosmjs-elements
branch
from
21655f9 to
f3c524e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm updating Hands on exercise, Cosmjs-adv section with Using telescope gen code instead of ts-proto and I found I also need to update the code here. And I think I also need to update the code gen part in branches derived from this branch(I'll do that after this change's reviewed)
And I also need to update the
clientproject in another PR with generated code using telescopeThank you very much!