Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade: add experimental option to reset overrides #3063

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Razaloc
Copy link
Contributor

@Razaloc Razaloc commented Aug 12, 2021

experimental ex-reset-overrides option allows resetting overrides before upgrading

Signed-off-by: Rafael G. Ruiz [email protected]

@openshift-ci
Copy link

openshift-ci bot commented Aug 12, 2021

Hi @Razaloc. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Razaloc
Copy link
Contributor Author

Razaloc commented Aug 12, 2021

I'm still testing it. It also fix a small format typo I found at line 1443

@lucab
Copy link
Contributor

lucab commented Aug 16, 2021

/ok-to-test

@jlebon
Copy link
Member

jlebon commented Aug 16, 2021

Do you have more background on this PR? I think having this option could make sense, though we should probably instead just enhance the global pkg_entries array or so to make it available in all the relevant commands.

@Razaloc
Copy link
Contributor Author

Razaloc commented Aug 17, 2021

As we wanted to handle pinning and unpinning pkgs to versions I think the idea was to undo the overrides at upgrade.

@jlebon
Copy link
Member

jlebon commented Aug 18, 2021

Let's hold this until we finalize the design in #1265.
/hold

@openshift-ci
Copy link

openshift-ci bot commented Mar 13, 2022

@Razaloc: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

experimental ex-reset-overrides option allows resetting overrides before upgrading

Signed-off-by: Rafael G. Ruiz <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Jun 6, 2023

@Razaloc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 1808734 link true /test images
ci/prow/build-clang 1808734 link true /test build-clang
ci/prow/clang-analyzer 1808734 link true /test clang-analyzer
ci/prow/fcos-e2e 1808734 link true /test fcos-e2e
ci/prow/kola-upgrade d93cab7 link true /test kola-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants