-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade: add experimental option to reset overrides #3063
base: main
Are you sure you want to change the base?
Conversation
Hi @Razaloc. Thanks for your PR. I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'm still testing it. It also fix a small format typo I found at line 1443 |
/ok-to-test |
Do you have more background on this PR? I think having this option could make sense, though we should probably instead just enhance the global |
As we wanted to handle pinning and unpinning pkgs to versions I think the idea was to undo the overrides at upgrade. |
Let's hold this until we finalize the design in #1265. |
@Razaloc: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
experimental ex-reset-overrides option allows resetting overrides before upgrading Signed-off-by: Rafael G. Ruiz <[email protected]>
@Razaloc: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
experimental ex-reset-overrides option allows resetting overrides before upgrading
Signed-off-by: Rafael G. Ruiz [email protected]