*: drop networkd section #703
Merged
+48
−606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
bgilbert
approved these changes
Jan 11, 2019
doc/migrating-configs.md
Outdated
| @@ -170,27 +170,6 @@ The `ignition` section has gained a new section named `security`, which can be u | |||
| } | |||
| ``` | |||
|
|
|||
| ### networkd dropins | |||
There was a problem hiding this comment.
I'm not sure we should be rewriting history like this. Instead, the migration instructions to version 3 should explain converting networkd units/dropins to regular files.
There was a problem hiding this comment.
Honestly we'll need a whole new migration guide anyway, so I'm not gunna be too picky about this.
There was a problem hiding this comment.
Dropped this change and opened up #705
Drop the networkd section from spec 3.0. networkd is not as widespread as systemd and everything done in this section can be accomplished in the files section. Fixes coreos#638
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the networkd section from spec 3.0. networkd is not as widespread
as systemd and everything done in this section can be accomplished in
the files section.
Fixes #638