Update azure priv fetch #2012
Open
Update azure priv fetch #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestist
force-pushed
the
update-azure-priv-fetch
branch
from
b46a576 to
e312ee8
Compare
jlebon
reviewed
Feb 7, 2025
prestist
force-pushed
the
update-azure-priv-fetch
branch
from
e312ee8 to
435a35d
Compare
|
Ok, I updated the commit with all changes minus the re-work one; I am working on the re-work but wanted to make sure I did not regress on the addressed comments; Expect a followup push. |
prestist
force-pushed
the
update-azure-priv-fetch
branch
3 times, most recently
from
5baea62 to
6a8da1a
Compare
jlebon
reviewed
Feb 13, 2025
prestist
force-pushed
the
update-azure-priv-fetch
branch
from
6a8da1a to
f826c55
Compare
prestist
force-pushed
the
update-azure-priv-fetch
branch
from
f826c55 to
0d5a46a
Compare
prestist
force-pushed
the
update-azure-priv-fetch
branch
from
0d5a46a to
0d52286
Compare
jlebon
reviewed
Feb 20, 2025
| f.Logger.Info("falling back to HTTP fetch") | ||
| } | ||
| } | ||
| if !isAzureBlob || err != nil { |
There was a problem hiding this comment.
What if it's an Azure blob but we don't have a session?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to the PR #1923
Add fallback logic, and add documentation.
cc: #2008