-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graph/index.html: Add onclick listener to fix navbar #51
Conversation
I don't think we should hardcode the URL in this file.. we should try to use relative URLs when possible (i.e. for one it makes development easier): Something like this gets me closer but I really shouldn't have the index.html in there diff --git a/graph/index.html b/graph/index.html
index 51c0057..4520b56 100644
--- a/graph/index.html
+++ b/graph/index.html
@@ -59,7 +59,7 @@ function zeroStream() {
<!-- Navbar -->
<nav class="navbar is-light" role="navigation" aria-label="main navigation">
<div class="navbar-brand">
- <a class="navbar-item" href="https://builds.coreos.fedoraproject.org/graph?stream=stable&basearch=x86_64"><img src="https://fedoraproject.org/assets/images/coreos-logo-light.png"/></a>
+ <a class="navbar-item" href="."><img src="https://fedoraproject.org/assets/images/coreos-logo-light.png"/></a>
</div>
<div class="navbar-end">
@@ -171,7 +171,7 @@ document.querySelectorAll('.navbar-item.has-dropdown a').forEach(item => {
});
function navigateToLink() {
- const url = `https://builds.coreos.fedoraproject.org/graph?stream=${selectedStream}&basearch=x86_64&infra=prod`;
+ const url = `./index.html?stream=${selectedStream}&basearch=x86_64&infra=prod`;
window.location.href = url; // executes the above and goes to the URL
}
// Return Cincinnati URL. |
is it possible to make the architecture selectable too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for tackling that ! Can you update the others selectors as well, like arch and add one for oci ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for tackling that ! Can you update the others selectors as well, like arch and add one for oci ?
Sure! Implemented in 82ff875 |
Removed the
I actually passed some values here, otherwise the link wouldn't work and we would get an error after clicking the coreos logo.
NP! Done. |
LGTM - this is working great! maybe in a followup PR we can add a selector for adding |
Can you copy this into place so the changes take effect at https://builds.coreos.fedoraproject.org/graph ? |
Fix: coreos/fedora-coreos-tracker#1868