Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to main, added BDD tests #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ScottONeal
Copy link

Thanks for this cool package!

In effort to try continue development on this module, I added basic BDD tests. To properly handle errors in the tests, I had to add basic error handling middleware to the lib/index.js.

To run tests:

npm install
npm test

Additionally, added a spawn event which passes the child_process instance. This could be useful to hooking into and logging command output or getting the exit code.

Also, I can add a .travis.yml if you would like.

@ScottONeal
Copy link
Author

@coreh, If you are looking for a new maintainer for this project, let me know. I use this module and several other do as well and would like to continue development on it, instead of duplicating it onto NPM.

Let me know how you would like to proceed with development efforts. Thanks!

@ScottONeal
Copy link
Author

ping @coreh Hey, any chance we can some attention on this repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant