Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Japanese-specific dependencies optional #2776

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Make Japanese-specific dependencies optional #2776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41d160f
Don't install MeCab by default
polm Jul 17, 2023
22d4b8e
Add optional [ja] deps, like [dev] etc
polm Jul 17, 2023
7f07dc3
Add JA requirements file
polm Jul 17, 2023
199d0f1
Add JA requirements to requirements_all
polm Jul 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion TTS/tts/utils/text/japanese/phonemizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@
import re
import unicodedata

import MeCab
try:
import MeCab
except ImportError:
raise ImportError("Japanese requires mecab-python3 and unidic-lite.")
from num2words import num2words

_CONVRULES = [
Expand Down
3 changes: 3 additions & 0 deletions requirements.ja.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# japanese g2p deps
mecab-python3==1.0.6
unidic-lite==1.0.8
3 changes: 0 additions & 3 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ coqpit>=0.0.16
# chinese g2p deps
jieba
pypinyin
# japanese g2p deps
mecab-python3==1.0.6
unidic-lite==1.0.8
# gruut+supported langs
gruut[de,es,fr]==2.2.3
# deps for korean
Expand Down
5 changes: 4 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@ def pip_install(package_name):
requirements_notebooks = f.readlines()
with open(os.path.join(cwd, "requirements.dev.txt"), "r") as f:
requirements_dev = f.readlines()
requirements_all = requirements_dev + requirements_notebooks
with open(os.path.join(cwd, "requirements.ja.txt"), "r") as f:
requirements_ja = f.readlines()
requirements_all = requirements_dev + requirements_notebooks + requirements_ja

with open("README.md", "r", encoding="utf-8") as readme_file:
README = readme_file.read()
Expand Down Expand Up @@ -113,6 +115,7 @@ def pip_install(package_name):
"all": requirements_all,
"dev": requirements_dev,
"notebooks": requirements_notebooks,
"ja": requirements_ja,
},
python_requires=">=3.9.0, <3.12",
entry_points={"console_scripts": ["tts=TTS.bin.synthesize:main", "tts-server = TTS.server.server:main"]},
Expand Down