Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kimai template #3435

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Add kimai template #3435

merged 1 commit into from
Oct 9, 2024

Conversation

nizetic
Copy link
Contributor

@nizetic nizetic commented Sep 14, 2024

Creating my first PR on this awesome project!

I have added Kimai template with yaml and svg as described in the docs.

The insance spins up and works as intended, there are some environment variables to help users with their setup. I would appreciate if you could have a look if the usage of variables seems okay to you.

Thanks!

@peaklabs-dev peaklabs-dev added the ⚙️ Service Issues requesting or PRs adding/fixing service templates. label Sep 14, 2024
Copy link

gitguardian bot commented Sep 19, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@nizetic
Copy link
Contributor Author

nizetic commented Oct 7, 2024

Could you give me a hand with this issue. I am looking into my docker compose and just don't understand that uncovered secrets issue

@peaklabs-dev
Copy link
Member

Thank you for the PR 💜. I will test it and fix it. The secrets are not in your compose so your are good.

@peaklabs-dev peaklabs-dev changed the base branch from next to new-services-3 October 9, 2024 15:14
@peaklabs-dev peaklabs-dev merged commit 6780bd8 into coollabsio:new-services-3 Oct 9, 2024
1 check passed
@github-actions github-actions bot removed the ⚙️ Service Issues requesting or PRs adding/fixing service templates. label Oct 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants