Use client and server for "ramalama run"

[ericcurtin]

To focus on vLLM server and llama-server being the endpoint

Summary by Sourcery

Refactor ramalama to use a client-server architecture.

Chores:

• Remove the ramalama-run-core and ramalama-serve-core scripts.
• Update exec_cmd to allow redirecting stderr to /dev/null.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request focuses on using vLLM server and llama-server as the endpoint. It removes the ramalama-run-core and ramalama-serve-core scripts and adds the ability to redirect standard error to null in the exec_cmd function.

Sequence diagram for exec_cmd with stderr redirection

Loading

sequenceDiagram
    participant Caller
    participant common
    participant os
    participant sys

    Caller->>common: exec_cmd(args, debug=False, stderr2null=True)
    alt stderr2null is True
        common->>os: open(os.devnull, 'w')
        os-->>common: devnull
        common->>os: dup2(devnull.fileno(), sys.stderr.fileno())
        os-->>common: Redirect stderr to devnull
    end
    common->>os: execvp(args[0], args)
    alt Exception
        os-->>common: Exception
        common-->>Caller: Exception
    else Success
        os-->>common: Return Code
        common-->>Caller: Return Code
    end

Updated class diagram for common.py

Loading

classDiagram
    class common {
      +exec_cmd(args, debug=False, stderr2null=False)
    }

File-Level Changes

Change	Details	Files
Added the ability to redirect standard error to null.	Added a stderr2null parameter to the exec_cmd function. When stderr2null is true, standard error is redirected to /dev/null.	ramalama/common.py
Removed ramalama-run-core and ramalama-serve-core.	Deleted the ramalama-run-core script. Deleted the ramalama-serve-core script.	libexec/ramalama-run-core libexec/ramalama-serve-core

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ericcurtin - I've reviewed your changes - here's some feedback:

Overall Comments:

• It's unusual to redirect stderr using os.dup2; consider using the subprocess module instead.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion (code-quality): Use f-string instead of string concatenation (use-fstring-for-concatenation)

Suggested change

	os.environ["PATH"] += os.pathsep + "libexec"
	os.environ["PATH"] += f"{os.pathsep}libexec"

[ericcurtin]

This is super messy, just to show people where I am going, nowhere near ready for merge.