Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:DOCS] Packit: clarify secondary status in CI #25478

Merged
merged 1 commit into from
Mar 5, 2025
Merged

[CI:DOCS] Packit: clarify secondary status in CI #25478

merged 1 commit into from
Mar 5, 2025

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Mar 5, 2025

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 5, 2025
@lsm5 lsm5 force-pushed the packit-failure-info-doc branch from 69c4459 to 47079cd Compare March 5, 2025 13:07
@packit-as-a-service Packit-as-a-Service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@lsm5 lsm5 marked this pull request as ready for review March 5, 2025 13:13
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2025
@lsm5
Copy link
Member Author

lsm5 commented Mar 5, 2025

Moving some CI info changes from #24369 for faster review and merge.

@containers/podman-maintainers PTAL

Luap99
Luap99 approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, I agree that this should make things much more clear.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mheon mheon added the No New Tests Allow PR to proceed without adding regression tests label Mar 5, 2025
@mheon
Copy link
Member

mheon commented Mar 5, 2025

LGTM, added No New Tests and restarted the failed job.

@lsm5
Copy link
Member Author

lsm5 commented Mar 5, 2025

/cherrypick v5.4

@openshift-cherrypick-robot
Copy link
Collaborator

@lsm5: once the present PR merges, I will cherry-pick it on top of v5.4 in a new PR and assign it to you.

In response to this:

/cherrypick v5.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Luap99
Copy link
Member

Luap99 commented Mar 5, 2025

[CI:DOCS]

BTW, most of these titles are gone as documented in https://github.com/containers/podman/blob/main/contrib/cirrus/CIModes.md

cirrus is smart enough to skip test based on changes sources no user should have use these titles.

@Luap99
Copy link
Member

Luap99 commented Mar 5, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit f10f326 into containers:main Mar 5, 2025
25 of 42 checks passed
@openshift-cherrypick-robot
Copy link
Collaborator

@lsm5: new pull request created: #25482

In response to this:

/cherrypick v5.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 5, 2025
Merged
@lsm5 lsm5 deleted the packit-failure-info-doc branch March 5, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luap99 Luap99 Luap99 approved these changes

Assignees

@Luap99 Luap99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. No New Tests Allow PR to proceed without adding regression tests release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lsm5 @mheon @openshift-cherrypick-robot @Luap99