New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: logs updated on starting of a stopped container #3896

Open

Shubhranshu153 wants to merge 1 commit into containerd:main from Shubhranshu153:fix-logs-on-attach

+88 −2

Contributor

Shubhranshu153 commented Feb 18, 2025 •

edited

Loading

Issue:

When we start a container that was running and stopped or exited, logs are not updated.

Steps to Reproduce:

step 1: Run and exit container

sudo nerdctl run -it --name test-1 alpine:latest
/ # echo hello
hello
/ # exit

start the same container

 sudo nerdctl start -a test-1
/ # echo bar
bar
/ # exit

Check logs. Bar is missing.

 sudo nerdctl logs test-1
/ # echo hello
hello
/ # exit

fix:

The pr fixes it by adding multiwriters to start of containers.

Shubhranshu153 force-pushed the fix-logs-on-attach branch 6 times, most recently from 49019a2 to ccb179d Compare

February 18, 2025 09:03

Contributor Author

Shubhranshu153 commented Feb 18, 2025

@AkihiroSuda
PTAL when you get a chance.
Thank You.

AkihiroSuda requested a review from fahedouch

February 19, 2025 02:47

AkihiroSuda added this to the v2.x.x (tentative) milestone

AkihiroSuda added the area/logging label

fahedouch reviewed

View reviewed changes

pkg/taskutil/taskutil.go Show resolved Hide resolved

Shubhranshu153 force-pushed the fix-logs-on-attach branch from ccb179d to e8fb6c4 Compare

February 20, 2025 18:32

Contributor

apostasie commented Feb 21, 2025

Docker failure is #3908

Rootful failure is #3513

apostasie reviewed

View reviewed changes

cmd/nerdctl/container/container_logs_test.go Outdated Show resolved Hide resolved

apostasie reviewed

View reviewed changes

cmd/nerdctl/container/container_logs_test.go Outdated Show resolved Hide resolved

apostasie reviewed

View reviewed changes

cmd/nerdctl/container/container_logs_test.go Outdated Show resolved Hide resolved

apostasie reviewed

View reviewed changes

cmd/nerdctl/container/container_logs_test.go Outdated Show resolved Hide resolved

apostasie reviewed

View reviewed changes

cmd/nerdctl/container/container_logs_test.go Outdated Show resolved Hide resolved

apostasie reviewed

View reviewed changes

cmd/nerdctl/container/container_logs_test.go Outdated Show resolved Hide resolved

apostasie reviewed

View reviewed changes

cmd/nerdctl/container/container_logs_test.go Outdated Show resolved Hide resolved

apostasie reviewed

View reviewed changes

cmd/nerdctl/container/container_logs_test.go Outdated Show resolved Hide resolved

apostasie reviewed

View reviewed changes

cmd/nerdctl/container/container_logs_test.go Outdated Show resolved Hide resolved

apostasie reviewed

View reviewed changes

cmd/nerdctl/container/container_logs_test.go Outdated Show resolved Hide resolved

Contributor

apostasie commented Feb 22, 2025

@Shubhranshu153 I just have a batch of nits on the test.

Btw, feedback on the test framework is highly welcome.

Ideally, if we get #3591 in first, we can get rid of the added DelayOnceReaders here (and unbuffer).

But anyhow, don't sweat it - I can clean that up afterwards if needed.

apostasie approved these changes

View reviewed changes

Shubhranshu153 force-pushed the fix-logs-on-attach branch 3 times, most recently from df70bc7 to 72193e6 Compare

February 24, 2025 18:20

apostasie reviewed

View reviewed changes

cmd/nerdctl/container/container_logs_test.go Outdated Show resolved Hide resolved

apostasie reviewed

View reviewed changes

pkg/testutil/testutil_freebsd.go Outdated Show resolved Hide resolved

Contributor Author

Shubhranshu153 commented Feb 25, 2025

Thanks the retry of the test passed.
@fahedouch @AkihiroSuda PTAL.

AkihiroSuda reviewed

View reviewed changes

cmd/nerdctl/container/container_logs_test.go Outdated Show resolved Hide resolved

AkihiroSuda reviewed

View reviewed changes

pkg/testutil/testutil_freebsd.go Outdated Show resolved Hide resolved

Shubhranshu153 force-pushed the fix-logs-on-attach branch from 64e9b6a to 35043f4 Compare

February 26, 2025 22:40

Shubhranshu153 closed this

Shubhranshu153 reopened this

Contributor

apostasie commented Feb 27, 2025

@Shubhranshu153 testing framework PR got merged.

Here is the TL;DR for you to update your PR:

package got moved to:
- github.com/containerd/nerdctl/mod/tigron/test
- github.com/containerd/nerdctl/mod/tigron/require
- github.com/containerd/nerdctl/mod/tigron/expect
test.Contains should be replaced with expect.Contains
test.Require is now require.All
test.Windows is now require.Windows
test.Not is now require.Not

TinaMor reviewed

View reviewed changes

pkg/taskutil/taskutil.go

    
              		if flagT {

              			in, err := consoleutil.NewDetachableStdin(con, detachKeys, closer)

              			if err != nil {

              				return nil, err

              			}

              			ioCreator = cio.NewCreator(cio.WithStreams(in, con, nil), cio.WithTerminal)

              			ioCreator = cioutil.NewContainerIO(namespace, logURI, true, in, con, nil)

Contributor

TinaMor Mar 10, 2025

@Shubhranshu153 Just out of curiosity, we are using logURI for logging here. Would it cause any issues like #3895?

Contributor Author

Shubhranshu153 Mar 11, 2025

it would, working on a separate PR for it.

Shubhranshu153 force-pushed the fix-logs-on-attach branch 2 times, most recently from f110c75 to ed7e0bc Compare

March 11, 2025 17:37

Shubhranshu153 closed this

Shubhranshu153 reopened this

Shubhranshu153 closed this

Shubhranshu153 reopened this

fahedouch approved these changes

View reviewed changes

Member

fahedouch left a comment

Thanks

Member

AkihiroSuda commented Mar 18, 2025

Needs rebase

AkihiroSuda modified the milestones: v2.0.4, v2.x.x

Shubhranshu153 force-pushed the fix-logs-on-attach branch from ed7e0bc to 3f66f20 Compare

March 24, 2025 22:28

Shubhranshu153 closed this

Shubhranshu153 reopened this

Shubhranshu153 closed this

Shubhranshu153 reopened this

Shubhranshu153 closed this

Shubhranshu153 reopened this

Shubhranshu153 closed this

Shubhranshu153 reopened this

Shubhranshu153 force-pushed the fix-logs-on-attach branch from 3f66f20 to 95a6f62 Compare

April 10, 2025 17:34


          fix: logs updated on starting of a stopped container

fc9c616

Signed-off-by: Shubharanshu Mahapatra <[email protected]>

Shubhranshu153 force-pushed the fix-logs-on-attach branch from 95a6f62 to fc9c616 Compare

April 10, 2025 17:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels