Add HostConfig to nerdctl inspect response
#3812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Jan 14, 2025
AkihiroSuda
reviewed
Jan 14, 2025
AkihiroSuda
reviewed
Jan 14, 2025
coderbirju
force-pushed
the
add-hostconfig-inspect-response
branch
from
f57dca7 to
cfdf044
Compare
AkihiroSuda
reviewed
Jan 15, 2025
coderbirju
force-pushed
the
add-hostconfig-inspect-response
branch
5 times, most recently
from
0b7af18 to
64ad424
Compare
coderbirju
changed the title
nerdctl inspect responsenerdctl inspect response
coderbirju
force-pushed
the
add-hostconfig-inspect-response
branch
19 times, most recently
from
7052b62 to
c5794d5
Compare
coderbirju
force-pushed
the
add-hostconfig-inspect-response
branch
3 times, most recently
from
f36f024 to
41ace87
Compare
|
@AkihiroSuda PTAL, I've tried to limit the use of labels and use the native inspect as much as possible. |
coderbirju
force-pushed
the
add-hostconfig-inspect-response
branch
from
41ace87 to
3721a3d
Compare
|
Bumping this PR for review. PTAL when you get a chance |
AkihiroSuda
reviewed
Feb 20, 2025
AkihiroSuda
reviewed
Feb 20, 2025
djdongjin
reviewed
Feb 20, 2025
coderbirju
force-pushed
the
add-hostconfig-inspect-response
branch
from
3721a3d to
17fe1b1
Compare
djdongjin
reviewed
Feb 24, 2025
coderbirju
force-pushed
the
add-hostconfig-inspect-response
branch
from
d6ca68f to
29883b4
Compare
This commit adds the following fields to the hostconfig struct that is retured when container inspect is called. - CIdFile - GroupAdd - Memory - CgroupNsMode - DNS config - OOMScoreAdj - ReadonlyRootfs - UTSMode - ShmSize - Runtime - Sysctl - Device - PidMode Signed-off-by: Arjun Raja Yogidas <[email protected]>
coderbirju
force-pushed
the
add-hostconfig-inspect-response
branch
from
29883b4 to
37d9958
Compare
|
@AkihiroSuda PTAL when you get some time. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nerdctl inspectcurrently doesn't report HostConfig details in its response.Attempting to add this PR as a starting point, aim is to get the
dockercompatresponse closer to the docker inspect response schema