Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-integration-rootless: enable BuildKit for RootlessKit v2 #3182

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Jul 5, 2024

BuildKit has been disabled in test-integration-rootless due to the issue #622, but this should not happen with RootlessKit v2 (detach-netns mode).

@AkihiroSuda AkihiroSuda added area/rootless Rootless mode area/ci e.g., CI failure labels Jul 5, 2024
@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Jul 5, 2024
@AkihiroSuda AkihiroSuda force-pushed the remove-workaround-622 branch from f24fa5b to a6a540d Compare July 5, 2024 11:36
@AkihiroSuda AkihiroSuda marked this pull request as draft July 5, 2024 11:36
@AkihiroSuda

This comment was marked as resolved.

BuildKit has been disabled in test-integration-rootless due to the issue
622, but this should not happen with RootlessKit v2 (detach-netns mode).

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda force-pushed the remove-workaround-622 branch from a6a540d to 019cd00 Compare July 5, 2024 12:16
@AkihiroSuda AkihiroSuda marked this pull request as ready for review July 5, 2024 13:22
@apostasie
Copy link
Contributor

LGTM

@AkihiroSuda AkihiroSuda requested review from fahedouch and ktock July 5, 2024 23:25
@fahedouch
Copy link
Member

fahedouch commented Jul 6, 2024

have you encountered the same problem outside of CI? If yes we may add some lignes to faq

@AkihiroSuda
Copy link
Member Author

have you encountered the same problem outside of CI? If yes we may add some lignes to faq

No

@AkihiroSuda AkihiroSuda merged commit 3acf57b into containerd:main Jul 6, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci e.g., CI failure area/rootless Rootless mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants