-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add repository login component username validation #3166
Conversation
55abe96
to
a11b578
Compare
Thanks @Shikachuu ! Left a couple of comments. |
Ngl I don't see any comments but this one, where should I find those? Checked the CI too, at first glance it doesn't seem login related. |
My bad - forgot to press the big green button to send these comments :p You should see them now. |
74e46ef
to
547df82
Compare
@Shikachuu can you rebase on the latest main? There has been some kerfuffle earlier on project checks (my fault). Hopefully rebasing should fix it. |
547df82
to
d739054
Compare
✔️ done, hopefully fixes it! |
d739054
to
a1b7a30
Compare
It does. LGTM as far as I am concerned (I am not a maintainer here, so, this is not formal approval). |
Signed-off-by: Czékus Máté <[email protected]>
a1b7a30
to
f630815
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Validate username in
login.go
commandFixes #3069