Sequence reset gap fill reverse verify logic #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vyourtchenko
force-pushed
the
SequenceReset_GapFill_Reverse_Verify_Logic
branch
5 times, most recently
from
65d1c6c to
154f39d
Compare
…msgs that reset the sequnece number with the same msgseqnum that caused the initial resendrequest
…DupFlag=Y a check on missing OrigSendingTime tag never runs
…pFlag=Y yet do not trigger DoTargetTooLow thus not checking for OrigSendingTime under the new logic
vyourtchenko
force-pushed
the
SequenceReset_GapFill_Reverse_Verify_Logic
branch
from
154f39d to
f281628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current logic in Session.NextSequenceReset causes SequenceReset messages with GapFill=Y to be ignored during message replay.
This change reverses the logic to fix the issue discussed here:
#309 (comment)