Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence reset gap fill reverse verify logic #784

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

oclancy
Copy link
Contributor

@oclancy oclancy commented Jul 14, 2023

Current logic in Session.NextSequenceReset causes SequenceReset messages with GapFill=Y to be ignored during message replay.
This change reverses the logic to fix the issue discussed here:
#309 (comment)

@CLAassistant
Copy link

CLAassistant commented Jul 14, 2023

CLA assistant check
All committers have signed the CLA.

@vyourtchenko vyourtchenko force-pushed the SequenceReset_GapFill_Reverse_Verify_Logic branch 5 times, most recently from 65d1c6c to 154f39d Compare February 21, 2025 21:40
Oliver Clancy and others added 5 commits February 21, 2025 16:07
…msgs that reset the sequnece number with the same msgseqnum that caused the initial resendrequest
…DupFlag=Y a check on missing OrigSendingTime tag never runs
…pFlag=Y yet do not trigger DoTargetTooLow thus not checking for OrigSendingTime under the new logic
@vyourtchenko vyourtchenko force-pushed the SequenceReset_GapFill_Reverse_Verify_Logic branch from 154f39d to f281628 Compare February 21, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants