chore: move third party notices generation to Semaphore promotion #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
rohitsanj
requested changes
Feb 14, 2025
.semaphore/third-party-notices.yml
Outdated
Comment on lines
31
to
32
| - sem-version java 21 | ||
| - . vault-setup |
There was a problem hiding this comment.
I believe these two lines are not needed. (I think they weren't needed for ide-sidecar either but that's fine).
Suggested change
| - sem-version java 21 | |
| - . vault-setup |
rohitsanj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
pulls out 3P notices to its own block
also updates ubuntu version
Pull request checklist
Other
.vsixfile?