Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scaffold service client #1015

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Conversation

noeldevelops
Copy link
Member

@noeldevelops noeldevelops commented Feb 4, 2025

Summary of Changes

  • Create a patch file to remove some of the internal info (contact, stag/dev) from the open api generated files
  • Replace clients/sidecar-openapi-specs/scaffolding-service.openapi.yaml with the latest version.
  • Use gulp apigen to automatically generate updated client code

Any additional details or context that should be provided?

Pull request checklist

Please check if your PR fulfills the following (if applicable):

Tests
  • Added new
  • Updated existing
  • Deleted existing
Other
  • All new disposables (event listeners, views, channels, etc.) collected as for eventual cleanup?
  • Does anything in this PR need to be mentioned in the user-facing CHANGELOG or README?
  • Have you validated this change locally by packaging and installing the extension .vsix file?
    gulp clicktest

@noeldevelops noeldevelops requested a review from a team as a code owner February 4, 2025 16:10
@noeldevelops noeldevelops requested a review from Copilot February 4, 2025 16:10

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12 out of 27 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • src/clients/scaffoldingService/models/ScaffoldV1TemplateList.ts: Evaluated as low risk
  • src/clients/scaffoldingService/models/ScaffoldV1TemplateCollectionMetadata.ts: Evaluated as low risk
  • src/clients/scaffoldingService/models/ApplyScaffoldV1TemplateRequest.ts: Evaluated as low risk
  • src/clients/scaffoldingService/models/ErrorSource.ts: Evaluated as low risk
  • src/clients/scaffoldingService/models/ScaffoldV1TemplateCollectionList.ts: Evaluated as low risk
  • src/clients/scaffoldingService/apis/TemplateCollectionsScaffoldV1Api.ts: Evaluated as low risk
  • src/clients/scaffoldingService/apis/TemplatesScaffoldV1Api.ts: Evaluated as low risk
  • src/clients/scaffoldingService/models/ScaffoldV1TemplateCollectionSpec.ts: Evaluated as low risk
  • src/clients/scaffoldingService/models/ScaffoldV1TemplateCollectionListDataInner.ts: Evaluated as low risk
  • src/clients/scaffoldingService/models/ScaffoldV1TemplateCollection.ts: Evaluated as low risk
  • src/clients/scaffoldingService/models/ScaffoldV1Template.ts: Evaluated as low risk
  • src/clients/scaffoldingService/models/ScaffoldV1TemplateCollectionListMetadata.ts: Evaluated as low risk
  • src/clients/scaffoldingService/models/ModelError.ts: Evaluated as low risk
  • src/clients/scaffoldingService/models/Failure.ts: Evaluated as low risk
  • src/clients/scaffoldingService/models/GlobalObjectReference.ts: Evaluated as low risk
@noeldevelops noeldevelops marked this pull request as draft February 5, 2025 14:10
@noeldevelops
Copy link
Member Author

noeldevelops commented Feb 12, 2025

Scaffold service will update to next version soon. [Not actually] Waiting on that, and we need to write a .PATCH to avoid including dev/stag urls, etc.

@noeldevelops noeldevelops marked this pull request as ready for review February 14, 2025 18:41
Copy link
Contributor

@rohitsanj rohitsanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@noeldevelops noeldevelops merged commit 3ae148d into main Feb 14, 2025
2 checks passed
@noeldevelops noeldevelops deleted the ncothren/scaffold-service-openapi branch February 14, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants