Generate third party notices PR as Semaphore promotion #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (1)
- pom.xml: Language not supported
rohitsanj
requested changes
Feb 14, 2025
rohitsanj
changed the title
rohitsanj
reviewed
Feb 14, 2025
There was a problem hiding this comment.
Context: I suggested to Lucia over DM that we could address #322 as part of this PR.
rohitsanj
reviewed
Feb 14, 2025
| @@ -26,7 +26,7 @@ | |||
| <properties> | |||
| <!-- Always build file system layout for Docker images --> | |||
| <docker.skip-build>false</docker.skip-build> | |||
| <!-- Never deploy to maven repository since make only builds CCloud Docker images --> | |||
| <!-- Never deploy to maven repository since make only builds Confluent Cloud Docker images --> | |||
There was a problem hiding this comment.
Context: This will help trigger the third party notices promotion once this PR is merged.
Analysis Details0 Issues
Coverage and Duplications
Project ID: ide-sidecar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #247 in part
Resolves #322
Summary of Changes
Run the block Update third party notices PR as a Semaphore promotion in parallel to the multi-arch-builds-and-upload promotion.
Any additional details or context that should be provided?
release pipeline should be a little faster