-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Avro non-record type deserialization #324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/main/java/io/confluent/idesidecar/restapi/messageviewer/RecordDeserializer.java:146
- Ensure that there are tests verifying the handling of non-record Avro types.
return OBJECT_MAPPER.valueToTree(genericObject);
nice! how do I set up this end-to-end clicktesting like in the screenshot? |
Here are the steps:
|
I have verified that this build works for the WeatherData topic, whose key schema specifies an AVRO primitive long, and whose body schema is an AVRO record. Can consume all ~874,459+ records from the topic. Set consumption mode to 'latest' to then get a gentle ~1 record per minute of realtime weather samples. |
Summary of Changes
Fixes #220
Proof that it works:
Why am I not writing an integration test for this? Well, that would require us to fix this exact problem on the serialization side of things, and that can wait for now.
Any additional details or context that should be provided?
Pull request checklist
Please check if your PR fulfills the following (if applicable):