Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move 3rd party notices to post-pipeline #321

Closed
wants to merge 2 commits into from

Conversation

Cerchie
Copy link
Contributor

@Cerchie Cerchie commented Feb 10, 2025

Summary of Changes

one of the low-hanging fruits listed here #247

wasn't sure whether to add it as a job under the main task or as a separate task... thoughtS?

Pull request checklist

Please check if your PR fulfills the following (if applicable):

  • Tests:
    • Added new
    • Updated existing
    • Deleted existing
  • Have you validated this change locally against a running instance of the Quarkus dev server?
    make quarkus-dev
  • Have you validated this change against a locally running native executable?
    make mvn-package-native && ./target/ide-sidecar-*-runner

@Cerchie Cerchie requested a review from a team as a code owner February 10, 2025 21:17
@Cerchie
Copy link
Contributor Author

Cerchie commented Feb 10, 2025

note: working on this ci failure:

Unprocessable YAML file.
Error: [{"Schema does not allow additional properties.", "#/after_pipeline/task/jobs/1/dependencies"}, {"Schema does not allow additional properties.", "#/after_pipeline/task/jobs/1/prologue"}, {"Schema does not allow additional properties.", "#/after_pipeline/task/jobs/1/run"}]

@Cerchie
Copy link
Contributor Author

Cerchie commented Feb 12, 2025

closing to read up on semaphore CI

@Cerchie Cerchie closed this Feb 12, 2025
@Cerchie Cerchie reopened this Feb 12, 2025
fi
# We don't want to update the third party notices when just the pom.xml version is bumped.
# Ugly, but it works.
# The commit message comes from the Make target "commit-release" in mk-files/semver.mk
promotions:
Copy link
Contributor

@rohitsanj rohitsanj Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Create a new pipeline file update-third-party-notices.yml
  2. Add commands to main job in the pipeline file update-third-party-notices.yml
  3. Add an auto promotion to main semaphore.yml file called "Update third party notices" with when condition as when: "branch =~ '.*' and change_in(['/pom.xml', '/NOTICE.txt'], {default_branch: 'main', branch_range: '$SEMAPHORE_GIT_COMMIT_RANGE', pipeline_file: 'ignore'})"

@Cerchie Cerchie closed this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants