Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tiledbsoma #28828

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

add tiledbsoma #28828

wants to merge 8 commits into from

Conversation

hadim
Copy link
Member

@hadim hadim commented Jan 13, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent but I have some suggestions.

File-specific lints and/or hints:

  • recipes/tiledbsoma/recipe.yaml:
    • hints:
      • It looks like you are submitting a multi-output recipe. In these cases, the correct name for the feedstock is ambiguous, and our infrastructure defaults to the top-level package.name field. Please add a feedstock-name entry in the extra section.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 13, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/tiledbsoma/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/tiledbsoma/recipe.yaml:

  • ❌ The recipe must have a build/number section.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12753303983. Examine the logs at this URL for more detail.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 13, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tiledbsoma/recipe.yaml) and found it was in an excellent condition.

@hadim hadim force-pushed the tiledbsoma branch 2 times, most recently from 35bf5f0 to 6cbea81 Compare January 13, 2025 20:38
@hadim

This comment was marked as resolved.

@hadim hadim marked this pull request as ready for review January 13, 2025 21:09
Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/sophios/meta.yaml:
    • lints:
      • Feedstock with the same name exists in conda-forge.
      • The following maintainers have not yet confirmed that they are willing to be listed here: sameeul. Please ask them to comment on this PR if they are.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@hadim
Copy link
Member Author

hadim commented Jan 14, 2025

@conda-forge/help-python-c @conda-forge/help-c-cpp ready for review!

@johnkerl
Copy link

Hello @hadim!

I would note that we have https://github.com/TileDB-Inc/tiledbsoma-feedstock on the tiledb channel -- if this is helpful to you.

@hadim
Copy link
Member Author

hadim commented Jan 15, 2025

Hello @hadim!

I would note that we have https://github.com/TileDB-Inc/tiledbsoma-feedstock on the tiledb channel -- if this is helpful to you.

Thanks! I noticed that feedstock indeed, but it seems best to have it on c-f for easier maintenance and allow other deps to depend on it (conda-forge/pytdc-feedstock#32 for example).

@johnkerl
Copy link

Thanks! I noticed that feedstock indeed, but it seems best to have it on c-f for easier maintenance and allow other deps to depend on it (conda-forge/pytdc-feedstock#32 for example).

💯 agreed! Glad to see you had already found our channel for reference. :)

Thank you!

@hadim
Copy link
Member Author

hadim commented Jan 15, 2025

@johnkerl should I add you as maintainer?

@johnkerl
Copy link

@hadim let's discuss with @ihnorton and @jdblischak -- and @jdblischak would be a great maintainer (better than I)

I would note that we use the name:

  • tiledbsoma-py -- Python
  • r-tiledbsoma -- R
  • libtiledbsoma -- C++

I note that this current PR uses the name tiledbsoma for Python

@hadim
Copy link
Member Author

hadim commented Jan 15, 2025

Noted I will switch to tiledbsoma-py then and the C++ lib is already called libtiledbsoma.


Anyone who wants to be a maintainer should explicitly say it in that PR, and I will add him.

@jdblischak
Copy link
Member

@hadim please add me as a recipe maintainer. Thanks!

@johnkerl
Copy link

@hadim please add me as a recipe maintainer. Thanks!

@hadim
Copy link
Member Author

hadim commented Jan 17, 2025

@conda-forge/help-python-c @conda-forge/help-c-cpp @conda-forge/staged-recipes ready for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants