-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tiledbsoma #28828
base: main
Are you sure you want to change the base?
add tiledbsoma #28828
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent but I have some suggestions. File-specific lints and/or hints:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/tiledbsoma/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12753303983. Examine the logs at this URL for more detail. |
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
35bf5f0
to
6cbea81
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
@conda-forge/help-python-c @conda-forge/help-c-cpp ready for review! |
Hello @hadim! I would note that we have https://github.com/TileDB-Inc/tiledbsoma-feedstock on the |
Thanks! I noticed that feedstock indeed, but it seems best to have it on c-f for easier maintenance and allow other deps to depend on it (conda-forge/pytdc-feedstock#32 for example). |
💯 agreed! Glad to see you had already found our channel for reference. :) Thank you! |
@johnkerl should I add you as maintainer? |
@hadim let's discuss with @ihnorton and @jdblischak -- and @jdblischak would be a great maintainer (better than I) I would note that we use the name:
I note that this current PR uses the name |
Noted I will switch to Anyone who wants to be a maintainer should explicitly say it in that PR, and I will add him. |
@hadim please add me as a recipe maintainer. Thanks! |
@hadim please add me as a recipe maintainer. Thanks! |
@conda-forge/help-python-c @conda-forge/help-c-cpp @conda-forge/staged-recipes ready for review! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).