Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build against both Gazebo Harmonic (gz-sim8) and Ionic (gz-sim9) #20

Merged
merged 5 commits into from
Feb 21, 2025

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Feb 20, 2025

Fix #15 .

The different version of the dependencies for Gazebo Harmonic and Gazebo Ionic are taken from https://github.com/gazebo-tooling/gazebodistro/blob/master/collection-harmonic.yaml and https://github.com/gazebo-tooling/gazebodistro/blob/master/collection-ionic.yaml .

Hopefully in the future the process of supporting multiple version in dependencies will be easier as the plan is for Gazebo libraries to stop being side-by-side installable (see gazebo-tooling/release-tools#1244), but in the meanwhile this solution should work fine. Note that in the gz-sim-yarp-plugins meta-package I changed the dependency on the libgz-sim-yarp-plugins from {{ pin_subpackage(cxx_name, exact=True) }} to {{ pin_subpackage(cxx_name, max_pin='x.x.x') }}, as if we start having multiple build variants of the same version number, the exact=True could have been confusing, as I am not sure on which specific build variant gz-sim-yarp-plugins would be depending.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@traversaro traversaro requested a review from xela-95 as a code owner February 20, 2025 17:52
@traversaro
Copy link
Contributor Author

@conda-forge-admin please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13441548325. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub Actions workflow below for more details. You can also ping conda-forge/core (using the @ notation) for further assistance or you can try rerendering locally.

The following suggestions might help debug any issues:

  • Is the recipe/{meta.yaml,recipe.yaml} file valid?
  • If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnnings.
  • Is the fork used for this PR on an organization or user GitHub account? Automated rerendering via the webservices admin bot only works for user GitHub accounts.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13441571179. Examine the logs at this URL for more detail.

@traversaro
Copy link
Contributor Author

@conda-forge-admin please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 20, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13442480808. Examine the logs at this URL for more detail.

@xela-95
Copy link
Contributor

xela-95 commented Feb 21, 2025

Super!

@traversaro traversaro merged commit eaf95e7 into conda-forge:main Feb 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build packages for both Gazebo Harmonic (gz-sim8) and Gazebo Ionic (gz-sim9)
3 participants