Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily pin jupyterlab<4 #31

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jrbourbeau
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

We're running into a few jupyterlab=4-related issues with the current labextension release (xref dask/dask-labextension#264, dask/dask-labextension#261). Folks are working jupyterlab=4 support (xref dask/dask-labextension#263), but I'd like to temporarily pin jupyterlab<4 in the meantime to avoid naive mamba install dask dask-labextension running into these issues

cc @jacobtomlinson

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jrbourbeau
Copy link
Member Author

@conda-forge-admin, please rerender

@jsignell
Copy link
Member

Just a note that jupyterlab 4 is already in the pangeo-notebook image and dask-labextension seems to be working. I haven't looked further than that though

@weiji14
Copy link
Member

weiji14 commented Jun 30, 2023

Just a note that jupyterlab 4 is already in the pangeo-notebook image and dask-labextension seems to be working. I haven't looked further than that though

We've got a bug report on dask-labextension not showing up properly at pangeo-data/pangeo-docker-images#467 with pangeo-docker-images=2023.06.20 that uses jupyterlab=4.0.2.

@jrbourbeau, note that you'll also need to apply a repodata patch for dask-labextension to https://github.com/conda-forge/conda-forge-repodata-patches-feedstock for this to work properly, otherwise mamba install would just pull an older version of dask-labextension that doesn't pin to jupyterlab<4. See instructions at https://github.com/conda-forge/conda-forge-repodata-patches-feedstock/blob/main/recipe/readme.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants