Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove need for GH token when linting for conda-forge #2063

Merged
merged 6 commits into from
Sep 18, 2024

Conversation

beckermr
Copy link
Member

@beckermr beckermr commented Sep 15, 2024

Checklist

  • Added a news entry
  • Regenerated schema JSON if schema altered (python conda_smithy/schema.py)

This PR

The idea here is three-fold:

  • separate staged-recipes code (which is more adhoc and moves quickly) from code for feedstocks (which moves at a slower pace) (see, e.g. the fix we had to push in PR fix: remove lint for changes to staged-recipes example #2038 due to a change in staged-recipes - we removed the lint there in favor of staged-recipes code and this PR follows that same logic to its conclusion.)
  • enable staged-recipes maintainers to help maintain the linter in ways that help them review recipes more efficiently without having to make a smithy PR and release (see, e.g., the custom github actions added currently for additional lints not covered by smithy).
  • remove the need for a GH token when linting for conda-forge in order to enable linting in isolated environments (as in conda-forge-feedstock-ops) with no permissions / tokens to enhance our security

The staged-recipes lints have been added to staged-recipes in PR conda-forge/staged-recipes#27590.

xref: #2043

@beckermr
Copy link
Member Author

pre-commit.ci autofix

@beckermr beckermr marked this pull request as ready for review September 16, 2024 04:21
@beckermr beckermr requested a review from a team as a code owner September 16, 2024 04:21
@beckermr
Copy link
Member Author

@conda-forge/core this PR is ready for review!

@beckermr
Copy link
Member Author

bump here @conda-forge/core

@beckermr beckermr merged commit 0134664 into main Sep 18, 2024
2 checks passed
@beckermr beckermr deleted the no-gh-token-cf-lint branch September 18, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants