Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove python 3.10 pin in run_win_build.bat template #2060

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

h-vetinari
Copy link
Member

For https://github.com/conda-forge/google-cloud-cpp-feedstock, I need to use an older lief due to conda-forge/lief-feedstock#45 causing the build to time out otherwise. This started failing recently, as our default python version in the image seems to have moved to 3.12, for which we have no lief<0.14 builds.

Once I add a python=3.11 pin to remote_ci_setup, things work out again, except on windows. See the diff for conda-forge/google-cloud-cpp-feedstock@ae95a6d in conda-forge/google-cloud-cpp-feedstock#183

diff --git a/.scripts/build_steps.sh b/.scripts/build_steps.sh
index 4552b6d..e9a5f15 100755
--- a/.scripts/build_steps.sh
+++ b/.scripts/build_steps.sh
@@ -34,9 +34,9 @@ CONDARC
 export CONDA_LIBMAMBA_SOLVER_NO_CHANNELS_FROM_INSTALLED=1

 mamba install --update-specs --yes --quiet --channel conda-forge --strict-channel-priority \
-    pip mamba conda-build conda-forge-ci-setup=4 "conda-build>=24.1" "py-lief<0.14"
+    pip mamba conda-build conda-forge-ci-setup=4 python=3.11 py-lief=0.12.3
 mamba update --update-specs --yes --quiet --channel conda-forge --strict-channel-priority \
-    pip mamba conda-build conda-forge-ci-setup=4 "conda-build>=24.1" "py-lief<0.14"
+    pip mamba conda-build conda-forge-ci-setup=4 python=3.11 py-lief=0.12.3

 # set up the condarc
 setup_conda_rc "${FEEDSTOCK_ROOT}" "${RECIPE_ROOT}" "${CONFIG_FILE}"
diff --git a/.scripts/run_osx_build.sh b/.scripts/run_osx_build.sh
index 9904c13..a247ce4 100755
--- a/.scripts/run_osx_build.sh
+++ b/.scripts/run_osx_build.sh
@@ -26,9 +26,9 @@ export CONDA_SOLVER="libmamba"
 export CONDA_LIBMAMBA_SOLVER_NO_CHANNELS_FROM_INSTALLED=1

 mamba install --update-specs --quiet --yes --channel conda-forge --strict-channel-priority \
-    pip mamba conda-build conda-forge-ci-setup=4 "conda-build>=24.1" "py-lief<0.14"
+    pip mamba conda-build conda-forge-ci-setup=4 python=3.11 py-lief=0.12.3
 mamba update --update-specs --yes --quiet --channel conda-forge --strict-channel-priority \
-    pip mamba conda-build conda-forge-ci-setup=4 "conda-build>=24.1" "py-lief<0.14"
+    pip mamba conda-build conda-forge-ci-setup=4 python=3.11 py-lief=0.12.3



diff --git a/.scripts/run_win_build.bat b/.scripts/run_win_build.bat
index e7275f3..712b303 100755
--- a/.scripts/run_win_build.bat
+++ b/.scripts/run_win_build.bat
@@ -24,7 +24,7 @@ set "CONDA_LIBMAMBA_SOLVER_NO_CHANNELS_FROM_INSTALLED=1"

 :: Provision the necessary dependencies to build the recipe later
 echo Installing dependencies
-mamba.exe install "python=3.10" pip mamba conda-build conda-forge-ci-setup=4 "conda-build>=24.1" "py-lief<0.14" -c conda-forge --strict-channel-priority --yes
+mamba.exe install "python=3.10" pip mamba conda-build conda-forge-ci-setup=4 python=3.11 py-lief=0.12.3 -c conda-forge --strict-channel-priority --yes
 if !errorlevel! neq 0 exit /b !errorlevel!

 :: Set basic configuration

That's because the windows setup scripts are the only ones that contain a separate python version pin, which conflicts in this case. Remove the 3.10 pin so that this is uniform across platforms.

@h-vetinari h-vetinari requested a review from a team as a code owner September 13, 2024 06:27
@beckermr
Copy link
Member

We've had a pin on windows since azure was added. @mariusvniekerk did that work over half a decade ago. I am fine removing it, but I am curious if anyone knows why it was there in the first place.

@h-vetinari
Copy link
Member Author

I think we should be able to try without big risks - I don't see why the behaviour would be different from the unix builds, where we don't have the pin either.

@beckermr
Copy link
Member

Did you try a job explicitly without a pin or just a job with an updated pin?

@h-vetinari
Copy link
Member Author

Did you try a job explicitly without a pin or just a job with an updated pin?

No I haven't but we can easily try.

@beckermr
Copy link
Member

Let's try a job like that with a custom rerender using this branch. If that works, then I say we merge.

@h-vetinari
Copy link
Member Author

Seems to be running fine in conda-forge/scipy-feedstock#284

@beckermr beckermr merged commit 6b155cb into conda-forge:main Sep 14, 2024
2 checks passed
@h-vetinari h-vetinari deleted the win310 branch September 14, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants