-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tools] Add system package manger with ncurses as example #177
Conversation
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be better to not have a test_package()
for it, but a regular other package recipe that uses it explicitly, so it is visible the if self.settings.os == "Linux": self.requires("ncurses/system")
explicitly
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Addressed on the commit 3874e44 Removed the test package, but added a "consumer" application instead. Also, adapted the CI strip to not only build both packages but also find and execute the new application. |
Signed-off-by: Uilian Ries <[email protected]>
The script test will run only for Linux because we need a system package manager for this example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, looking good
Signed-off-by: Uilian Ries <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Add extra support for Mac (homebrew) and FreeBSD (pkg): |
Signed-off-by: Uilian Ries <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Co-authored-by: Carlos Zoido <[email protected]>
Co-authored-by: Carlos Zoido <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Great, good job! |
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
@memsharded @czoido I just skipped the example app execution on the commit e3607c1 As we are using ncurses, it will need a configured terminal, which is not the case in the current CI that's building the examples. We could handle terminfo as workaround, but sounds too much. Locally, we should not have this problem when running the application. |
Related to conan-io/docs#3974
Documentation PR: conan-io/docs#3978