sqlite3 localdb: using single quotes for strings backport (#16123)

[balazon]

A newer version of sqlite3 breaks double quotes on 1.x
https://www.reddit.com/r/freebsd/comments/1chb82b/sqlite3_pkg_just_became_stricter_with_quoting/

There are multiple issues relevant for this bug, for example:
#13446
#16115
The latter was fixed on v2.x here:
#16123
But 1.x still suffers from this, and some of us are still stuck on 1.x, so before we can update to 2.x, could we have this fix please?

Thanks

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[memsharded]

Hi @balazon

Thanks for your contribution.

The main problem with this is that Conan 1 development and release is now frozen in practice. Conan 2 is now more than 2 years old (almost 4 years counting with alphas and betas).

The main issue is that we moved some time ago to GH actions for CI, but we didn't port the Conan 1.X pipeline. So it can be challenging to build, test and release such a new version for Conan 1.

[balintvarga-stla]

I've just seen an 1.67.0-dev version on the develop branch, which is only 3 months old 😂
I thought hm I could put this change on top of that, and hopefully this gets to be on pypi soon.
Maybe we do should check v2.x out soon, can't be that hard. But I really needed a quick fix.
If it can't be deployed I guess it's fine, at least now I know what causes the issue, and I can use an editable source build or a built wheel until we switch to 2.x
Edit: this is still balazon - sorry for the confusion, just a different account

[memsharded]

Yes, the migration to GH actions happened in December:

• Test github actions for Linux #17094
• [Windows] GH Actions #17205

So yes, about 3 months since then, aligned with last Conan 1.66 release in December: https://docs.conan.io/1/changelog.html
But that release was already almost empty, and the previous one Conan 1.65 dates back to August, almost empty too.

Isn't it possible to hold the update of sqlite3? That would be the recommendation, just stick with the working versions, isn't it?

I'll check what is possible with the team, but this seems quite challenging, it might be that the migration of the CI to GH actions was the last nail on Conan 1.

[balazon]

Isn't it possible to hold the update of sqlite3?

Yes it is. My options now seem to be:

• use forked conan with the fix, either editable or built wheel
• downgrade libsqlite
• update project to conan 2.x

The way I noticed this problem was quite subtle though, because I just created a new mamba environment, didn't change a thing, and my build still failed. Turns out new mamba environments installs the latest libsqlite 3.49.1 by default, so that's what broke it. Downgrading libsqlite inside an existing environment deletes pip as well though, so it's best to specify libsqlite version at the time of creating the environment with eg:
mamba create -n myenv python=3.13 libsqlite=3.48.0

Best longterm solution is I think to update the recipes to 2.x, doesn't look too bad

[memsharded]

Thanks for the feedback

Best longterm solution is I think to update the recipes to 2.x, doesn't look too bad

Yes, please, this should be a priority:

• ConanCenter stopped getting fixes, updates and new versions for Conan 1 some time ago already: https://blog.conan.io/2024/09/30/Conan-Center-will-stop-receiving-updates-for-Conan-1.html
• Conan client is no longer getting fixes and releases. This means it might be using outdated Python dependencies that might have security issues coming up at any time, and it won't be possible to update, that is a security risk. But also there won't be support for new compilers, for example latest VS 17.10 and higher updates are not supported.
• Conan 2 has released tons of very high demanded features and improvements, things that were waiting for years in Conan 1 because they were impossible due to the debt, it is a much better tool.

The only issue is that it might not be that straightforward, depending on the current state of your recipes, if you have already modernized them into the Conan 1 new tools, or using legacy Conan 1 tools, the migration effort might be high. The thing is that it was planned as a long term effort, as commented, alphas and betas of Conan 2 started practically 4 years ago, and some of the features necessary to migrate (revisions, crosss-building, new generators) have been in Conan 1 for many, many years.