adding premake to CI #17765
Merged
adding premake to CI #17765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Comment on lines
+152
to
+154
| RUN wget https://github.com/premake/premake-core/releases/download/v5.0.0-beta4/premake-5.0.0-beta4-linux.tar.gz && \ | ||
| tar -xvzf premake-5.0.0-beta4-linux.tar.gz && chmod +x premake5 && mkdir /usr/share/premake && \ | ||
| mv premake5 /usr/share/premake |
There was a problem hiding this comment.
Let's declare above something like:
BAZEL_8=8.0.0 \
PREMAKE_5=5.0.0So we can use it here as:
RUN wget https://github.com/premake/premake-core/releases/download/v${PREMAKE_5}-beta4/premake-${PREMAKE_5}-beta4-linux.tar.gz && \
tar -xvzf premake-${PREMAKE_5}-beta4-linux.tar.gz && chmod +x premake5 && mkdir /usr/share/premake && \There was a problem hiding this comment.
I don't plan to add or support more than 1 premake version in Conan and CI, do you think it is still necessary?
franramirez688
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Omit
Docs: Omit
Just provision Premake in CI, only in Linux at the moment.
To prepare CI for #17398