Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mcf threading model for GCC on Windows to the default_settings #17704

Merged

Conversation

elvisdukaj
Copy link
Contributor

@elvisdukaj elvisdukaj commented Feb 5, 2025

Changelog: Feature: Add mcf threading for gcc MinGW compiler settings.yml
Docs: Omit

Since the introduction of the mingw-builds/13.2.0 with this PR, GCC now support an additional threading model which is called "mcf".

But this setting is missing from the default configuration which in practice means that mingw-builds is not working out of the box, see packag_info()

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@CLAassistant
Copy link

CLAassistant commented Feb 5, 2025

CLA assistant check
All committers have signed the CLA.

@elvisdukaj elvisdukaj changed the title Feature: default_settings: adding "mcf" threading model to GCC on Windows Add "mcf" threading model for GCC on Windows to the default_settings Feb 5, 2025
@elvisdukaj elvisdukaj changed the title Add "mcf" threading model for GCC on Windows to the default_settings Add mcf threading model for GCC on Windows to the default_settings Feb 5, 2025
@memsharded
Copy link
Member

Thanks for your contribution @elvisdukaj

Please check the CLA, it seems it has not been signed. Sometimes it happens if using a different email for the commit than the one used in Github.

Since the introduction of the mingw-builds/13.2.0 with
conan-io/conan-center-index#23481 PR, GCC now
support an additional threading model which is called mcf. But this
settings is missing from the default configuration
@elvisdukaj elvisdukaj force-pushed the edukaj/add_mfc_option_to_gcc branch from e7a4cec to 889cef9 Compare February 6, 2025 18:31
@memsharded memsharded added this to the 2.13.0 milestone Feb 7, 2025
@memsharded memsharded self-assigned this Feb 7, 2025
@memsharded memsharded merged commit db922a4 into conan-io:develop2 Feb 7, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants