Skip to content

[hotfix] Update CMake target for protobuf #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2023

Conversation

uilianries
Copy link
Member

According to the official documentation, the Protobuf target for its libraries should be protobuf::libprotobuf:

https://cmake.org/cmake/help/latest/module/FindProtobuf.html

kudos to SpaceIM

@memsharded memsharded merged commit 6e47be2 into conan-io:master May 25, 2023
@memsharded
Copy link
Member

Merged, but are we sure it is working fine in the examples2 code? I guess it does, because it is tested, maybe it was a copy&paste error?

@uilianries
Copy link
Member Author

Merged, but are we sure it is working fine in the examples2 code? I guess it does, because it is tested, maybe it was a copy&paste error?

It works both cases. The protobuf::libprotobuf and protobuf::protobuf are virtually the same thing. The difference is that protobuf::protobuf is generated by default by Conan client, and protobuf::libprotobuf is the expected target by the official documentation.

I just opened a PR now to examples2, fixing it there too: conan-io/examples2#103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants