refactor: migrate golang.org/x/exp to stds #736
Conversation
morlay
force-pushed
the
remove-x-exp
branch
2 times, most recently
from
c5e2d13 to
f2ac5c1
Compare
| @@ -120,21 +121,21 @@ func (p *Project) ServicesWithBuild() []string { | |||
| servicesBuild := p.Services.Filter(func(s ServiceConfig) bool { | |||
| return s.Build != nil && s.Build.Context != "" | |||
| }) | |||
| return maps.Keys(servicesBuild) | |||
| return slices.AppendSeq(make([]string, 0), maps.Keys(servicesBuild)) | |||
There was a problem hiding this comment.
slices.Collect will return nil which break testing.
There was a problem hiding this comment.
Why is AppendSeq required here, as maps.Keys already return a []string?
There was a problem hiding this comment.
ok got it. Then I don't understand you don't use slices.Collect which does the exact same afaict (https://github.com/golang/go/blob/go1.23.0/src/slices/iter.go#L56-L59)
There was a problem hiding this comment.
https://github.com/golang/go/blob/go1.23.0/src/slices/iter.go#L58
cause it nil slice as defaults, which will break the testings,
and i have no idea to update testings.
There was a problem hiding this comment.
testing uses assert.DeepEqual(t, []string{}, p.ServicesWithBuild()), you can just switch to assert.Equal(t, 0, len(p.ServicesWithBuild()) as nil and empty slice should be considered equivalent
|
compose-go declares requirement on go 1.21, while those func have been introduced in 1.23 |
Signed-off-by: Morlay <[email protected]>
fix #735