Temporarily specify the Windows SDK version #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steelskin
force-pushed
the
fabrice/override-win-sdk
branch
from
67645cf to
11e5161
Compare
compnerd
approved these changes
Mar 4, 2025
Steelskin
force-pushed
the
fabrice/override-win-sdk
branch
8 times, most recently
from
4cb52e9 to
0122156
Compare
Steelskin
force-pushed
the
fabrice/override-win-sdk
branch
6 times, most recently
from
0c47103 to
74b4b5d
Compare
Steelskin
force-pushed
the
fabrice/override-win-sdk
branch
from
74b4b5d to
3857d48
Compare
|
@compnerd Could I ask you to take another look at the updated patch? This finally passed: I want to test our other bots before I land this. |
This is necessary to work around an issue with the latest version (26100) of the Windows SDK where changes in headers result in circular module dependencies. For the compilers build, this installs and uses MSVC 14.42 because the current build does not work with MSVC 14.43. In addition, this removes the 26100 Windows SDK to get the compilers to build until the bootstrap toolchain supports the new SDK. See #909 for details.
Steelskin
force-pushed
the
fabrice/override-win-sdk
branch
from
3857d48 to
d7a223d
Compare
compnerd
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to work around an issue with the latest version (26100) of the Windows SDK where changes in headers result in circular module dependencies.
See #909 for details.