Skip to content

Resolve error preventing nearby uploads from linking to Wikidata entities #6142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

Resolve error preventing nearby uploads from linking to Wikidata entities #6142

wants to merge 13 commits into from

Conversation

Sujal-Gupta-SG
Copy link
Contributor

@Sujal-Gupta-SG Sujal-Gupta-SG commented Jan 18, 2025 •
edited
Loading

Fixes #6123

savsch and others added 10 commits January 15, 2025 22:52
@savsch @nicolas-raoul
Fix NPE with UploadMediaDetails.captionText (commons-app#6128)
62136b5 
Co-authored-by: Nicolas Raoul <[email protected]>
@Sujal-Gupta-SG
Migrated Java profile package to kotlin (commons-app#6119)
70291a0 
* Rename .java to .kt

* Migrate Profile Package to Kotlin commons-app#6118 commons-app#5928

* Migrate Profile Package to Kotlin commons-app#6118 commons-app#5928

* Migrate Profile Package to Kotlin commons-app#6118 commons-app#5928
@andy-ife @nicolas-raoul
change status bar color to grey in dark mode (commons-app#6120)
16ac08f 
Co-authored-by: Nicolas Raoul <[email protected]>
@savsch
Share login state with SingleWebViewActivity (commons-app#6136)
1f33926
@savsch
If depicted Wikidata item has no associated Commons category property…
1e64acd 
…, then suggest categories from its P18 (commons-app#6130)

* Fix NPE with UploadMediaDetails.captionText

* Store P18 instead of processed image url in DepictedItem

* Add routes for fetching category info from titles

* Consider depict's P18 when suggesting categories

* Add tests

* Corrected DepictedItem constructor arguments

* Add test for DepictedItem::primaryImage
@translatewiki
Localisation updates from https://translatewiki.net.
2d6583f
@Sujal-Gupta-SG
fix/handle-shared-files-and-error-handling
c4147a8
@Sujal-Gupta-SG
fix/handle-shared-files-and-error-handling
f84f524
@Sujal-Gupta-SG
fix/handle-shared-files-and-error-handling
aa6d109
@Sujal-Gupta-SG
fix/handle-shared-files-and-error-handling
41f71d8
nicolas-raoul
nicolas-raoul requested changes Jan 18, 2025
View reviewed changes
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a draft PR, or does this branch actually fix the issue when you test it? Please be sure to follow the reproduction steps listed in the issue. Thanks!

This branch does not fix the issue unfortunately:
Screenshot_20250119-080026.png

@Sujal-Gupta-SG Sujal-Gupta-SG marked this pull request as draft January 19, 2025 07:00
@Sujal-Gupta-SG Sujal-Gupta-SG marked this pull request as ready for review January 19, 2025 14:06
@Sujal-Gupta-SG
Copy link
Contributor Author

Sujal-Gupta-SG commented Jan 19, 2025 •
edited
Loading

Is this a draft PR, or does this branch actually fix the issue when you test it? Please be sure to follow the reproduction steps listed in the issue. Thanks!

This branch does not fix the issue unfortunately: Screenshot_20250119-080026.png

@nicolas-raoul Can you check it now if there any problem i will try again to solve it and if you try to upload downloaded images please crop it afterwards it can get uploaded easily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-raoul nicolas-raoul Awaiting requested review from nicolas-raoul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nearby upload not being linked from Wikidata
5 participants
@Sujal-Gupta-SG @nicolas-raoul @savsch @andy-ife @translatewiki