Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue #5829 Cancelled upload is considered as Queued even when try to upload again #5869

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fixed issue #5829 Cancelled upload is considered as Queued even when try to upload again #5869

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
17a0352
fixed issue #5829
Oct 18, 2024
7e1d3b3
Merge branch 'main' into 1-issue#5829
nicolas-raoul Oct 19, 2024
7631dfb
Merge branch 'main' into 1-issue#5829
nicolas-raoul Dec 13, 2024
02a2bdc
Merge branch 'main' into 1-issue#5829
nicolas-raoul Jan 8, 2025
045cfa2
Merge branch 'main' into 1-issue#5829
nicolas-raoul Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ class PendingUploadsFragment :

/**
* Cancels a specific upload after getting a confirmation from the user using Dialog.
* And if the deleted upload is the last one, will set app off paused, allowing a fresh new start for future uploads.
*/
override fun deleteUpload(contribution: Contribution?) {
val activity = requireActivity()
Expand All @@ -128,6 +129,8 @@ class PendingUploadsFragment :
String.format(locale, activity.getString(R.string.yes)),
String.format(locale, activity.getString(R.string.no)),
{
if(contributionsList.size== 1)
{CommonsApplication.isPaused = false}
ViewUtil.showShortToast(context, R.string.cancelling_upload)
pendingUploadsPresenter.deleteUpload(
contribution, requireContext().applicationContext,
Expand Down