Add old data to the preupdate event #240
Conversation
| guardNoAttributes(); | ||
| guardReadOnly(); | ||
| mergeAttributesFromCastCache(); | ||
| fireEvent( "preSave", { entity : this } ); | ||
| variables._saving = true; | ||
| var builder = newQuery(); | ||
| if ( variables._loaded ) { | ||
| fireEvent( "preUpdate", { entity : this } ); | ||
| fireEvent( "preUpdate", { entity : this, oldData : oldData } ); |
There was a problem hiding this comment.
I’m going to need tests around this, specifically because I don’t think this is correct. variables._data here will be the data about to be saved.
I think you want variables._originalAttributes which can also be retrieved calling get_originalAttributes() on the entity, which is why nothing extra has been passed in
There was a problem hiding this comment.
You are right, inside the preUpdate() I can access arguments.eventdata.entity.get_originalAttributes() and get the orginal data.
Maybe could be document this in the preUpdate() doc? (I think is a common use of preUpdate to access the original data)
There was a problem hiding this comment.
Thinking about it some more, I think it's okay to pass the original attributes to this method, even though it's also available via the entity.
Passing the current data might be a good option as well. It's a little unwieldy to get the original attributes right now. A method like retrieveOriginalAttributes or retrieveOriginalData would be a good addition as well.
There was a problem hiding this comment.
Cborm and hibernate sends the old data to preupdate event. Just for compatibility with others orm I think it's good to have the same behaviour.
Send the old data of the entity in the preUpdate event.
#239