-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal to add ability to use CIDR signatures for IP addresses in coldbox rules #45
base: development
Are you sure you want to change the base?
Proposal to add ability to use CIDR signatures for IP addresses in coldbox rules #45
Conversation
I think this looks great. Let me know when you want me to finalize and merge. |
@ryanalbrecht is this ready to be merged? |
@lmajano Good morning Luis, Thinking about it I would like a couple more days to work on the ip module. The validation code for an ip address when instating the cfc could use some love. Will let you know when Im comfortable sending this out into the wild. Regards |
No problem at all. We can also assist with your IP module if you like. I know @bdw429s loves that kinda stuff! |
Sure, I will shoot him a message on slack |
Any updates on this PR @ryanalbrecht |
@lmajano Unfortunately I have not done any further development, I have been a bit swamped lately. I do actually intend to use this in one of the projects im working on so I will definitely get this code committed soon |
Ready to commit, is it possible to rerun the tests to make sure all are passing? |
Description
I have a need to allow entire subnets access to a particular application. I would like to propose the following changes to allow this. This is fairly a big change due to a new module dependency so would like to hear your thoughts on this.
Please note that all PRs must have tests attached to them
tests to follow
Type of change
I have written and published a new module ( https://forgebox.io/view/ip ) and made changes to cbSecurity to use it so as to allow for CIDR addresses.
Checklist