Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Set compile target to java 8 #222

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

shaundmorris
Copy link
Member

@shaundmorris shaundmorris commented Apr 6, 2021

DO NOT MERGE

This PR tests compiling with Java 11 and target set to 8 for compatibility


This change is Reviewable

Compiles with Java 11, with target set to 8 for compatibility
@bradh
Copy link
Contributor

bradh commented Apr 7, 2021

@shaundmorris Doesn't look like that is going to work (see CI build failure). What is the problem you're trying to solve with this?

@shaundmorris shaundmorris changed the title Set compile target to java 8 WIP Set compile target to java 8 Apr 19, 2021
@shaundmorris
Copy link
Member Author

@bradh I was trying to figure out a way to have both java 8 and 11 build and run compatibility at the same time. Was experimenting with it.

@bradh
Copy link
Contributor

bradh commented Apr 19, 2021

I thought we agreed there was no need for JDK 8 any more?

Do we need to revisit that?

@bradh bradh marked this pull request as draft April 22, 2021 07:02
@shaundmorris
Copy link
Member Author

This was an experiment to see if there is an easy way to support both on the same branch. I like the idea of moving master forward with Java 11. Previous branches can still rely on 8. So I would like to release master again with 11 support if you are okay with that @bradh

@bradh
Copy link
Contributor

bradh commented Apr 25, 2021

@shaundmorris No problem with a release.

@bradh
Copy link
Contributor

bradh commented Oct 15, 2021

@shaundmorris What is the status on this PR? Are we moving forward with java 11 only?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants