-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not run/Skipped test reporting #13
base: master
Are you sure you want to change the base?
Conversation
…x time is reached
codice-itest-impl/src/main/java/org/codice/itest/reporter/TestReporterConfiguration.java
Outdated
Show resolved
Hide resolved
codice-itest-impl/src/main/java/org/codice/itest/reporter/RemainingTestsReporter.java
Outdated
Show resolved
Hide resolved
codice-itest-impl/src/main/java/org/codice/itest/SkipAwareExecutorService.java
Outdated
Show resolved
Hide resolved
codice-itest-impl/src/main/java/org/codice/itest/result/TestResultFactoryImpl.java
Outdated
Show resolved
Hide resolved
codice-itest-impl/src/main/java/org/codice/itest/reporter/LoggingDiagnosticTestReporter.java
Outdated
Show resolved
Hide resolved
codice-itest-impl/src/main/java/org/codice/itest/result/TestResultFactoryImpl.java
Outdated
Show resolved
Hide resolved
@knekylen-smith Are there any hero instructions that can be included in the description? |
To be honest I am not sure. Building it was a success and testing it would require a case where one test runs past the max time allowing for another test to not be run to see it in action. |
codice-itest-impl/src/main/java/org/codice/itest/SkipAwareExecutorService.java
Outdated
Show resolved
Hide resolved
❓ @dcruver I noticed the new classes didn't have the Codice header info. Is that required? |
codice-itest-impl/src/main/java/org/codice/itest/result/NotExecutedTestResultImpl.java
Outdated
Show resolved
Hide resolved
You could probably just set the time limit very low and a sleep that exceeds it in an itest. |
Good idea I will try that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were you able to test this somehow to confirm that the new reporting works? Also, I know this project doesn't have a lot of testing, but it could help to add some units tests to prevent regression going forward.
codice-itest-impl/src/main/java/org/codice/itest/reporter/TestReporterConfiguration.java
Show resolved
Hide resolved
codice-itest-impl/src/main/java/org/codice/itest/SkipAwareExecutorService.java
Outdated
Show resolved
Hide resolved
I am working on testing that method that you suggested. I haven't officially made progress as I started working on something else, but I will implement the changes you guys are suggesting and also test them out today. |
Created a reporter that notifies when tests are not executed after max time is reached.