Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not run/Skipped test reporting #13

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

knekylen-smith
Copy link

Created a reporter that notifies when tests are not executed after max time is reached.

@knekylen-smith knekylen-smith changed the title Created a reporter that notifies when tests are not executed after ma… Not run/Skipped test reporting May 18, 2023
@jhunzik jhunzik requested review from dcruver and mcalcote May 18, 2023 17:21
@mcalcote
Copy link
Contributor

@knekylen-smith Are there any hero instructions that can be included in the description?

@knekylen-smith
Copy link
Author

knekylen-smith commented May 18, 2023

@knekylen-smith Are there any hero instructions that can be included in the description?

To be honest I am not sure. Building it was a success and testing it would require a case where one test runs past the max time allowing for another test to not be run to see it in action.

@mcalcote
Copy link
Contributor

@dcruver I noticed the new classes didn't have the Codice header info. Is that required?

@jhunzik
Copy link
Contributor

jhunzik commented May 18, 2023

@knekylen-smith Are there any hero instructions that can be included in the description?

To be honest I am not sure. Building it was a success and testing it would require a case where one test runs past the max time allowing for another test to not be run to see it in action.

You could probably just set the time limit very low and a sleep that exceeds it in an itest.

@knekylen-smith
Copy link
Author

knekylen-smith commented May 19, 2023

@knekylen-smith Are there any hero instructions that can be included in the description?

To be honest I am not sure. Building it was a success and testing it would require a case where one test runs past the max time allowing for another test to not be run to see it in action.

You could probably just set the time limit very low and a sleep that exceeds it in an itest.

Good idea I will try that

@knekylen-smith knekylen-smith deleted the NotRunTestReporting branch May 19, 2023 13:29
@knekylen-smith knekylen-smith restored the NotRunTestReporting branch May 19, 2023 13:29
Copy link
Contributor

@jhunzik jhunzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to test this somehow to confirm that the new reporting works? Also, I know this project doesn't have a lot of testing, but it could help to add some units tests to prevent regression going forward.

@knekylen-smith
Copy link
Author

I am working on testing that method that you suggested. I haven't officially made progress as I started working on something else, but I will implement the changes you guys are suggesting and also test them out today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants