Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glossary.yml #36

Merged
merged 12 commits into from
Jul 13, 2020
Merged

Update glossary.yml #36

merged 12 commits into from
Jul 13, 2020

Conversation

Blind4Basics
Copy link
Contributor

do not merge yet: I'm making tries about internal links from one point to another of the glossary

@Blind4Basics
Copy link
Contributor Author

Blind4Basics commented Jul 13, 2020

DX

How the f... can I get useful feedback about what I'm doing wrong, in there? x/

(-> where do I drop the usual Don't use Test.expect thing? x) )

@kazk
Copy link
Member

kazk commented Jul 13, 2020

Just check the output:
image

image

@kazk
Copy link
Member

kazk commented Jul 13, 2020

You're using the colon again in unquoted string.

@Blind4Basics
Copy link
Contributor Author

Damn it... XD

thx

@kazk
Copy link
Member

kazk commented Jul 13, 2020

Maybe just always use the multiline string.

@Blind4Basics
Copy link
Contributor Author

Blind4Basics commented Jul 13, 2020

Ready for reviewing.
#23 is up to date, if needed to track down the last changes

Note: how is it that sometimes the lint check just hangs forever? (seems like it happens when the "Prettier" thing is showing up)

@kazk
Copy link
Member

kazk commented Jul 13, 2020

Note: how is it that sometimes the lint check just hangs forever? (seems like it happens when the "Prettier" thing is showing up)

Yeah, that's auto committed by a tool when there's an issue with formatting and apparently it doesn't re-trigger the checks. I'm looking into an alternative way.

@kazk
Copy link
Member

kazk commented Jul 13, 2020

Thanks. We'll iterate on some descriptions later to clarify things.

@kazk kazk merged commit f18bdf2 into master Jul 13, 2020
@kazk kazk deleted the glossary2 branch July 13, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants