Skip to content

Commit

Permalink
nnbd migration
Browse files Browse the repository at this point in the history
  • Loading branch information
letsar committed Oct 31, 2020
1 parent f417b19 commit 31bb071
Show file tree
Hide file tree
Showing 10 changed files with 653 additions and 330 deletions.
180 changes: 180 additions & 0 deletions all_lint_rules.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,180 @@
linter:
rules:
- always_declare_return_types
- always_put_control_body_on_new_line
- always_put_required_named_parameters_first
- always_require_non_null_named_parameters
- always_specify_types
- always_use_package_imports
- annotate_overrides
- avoid_annotating_with_dynamic
- avoid_as
- avoid_bool_literals_in_conditional_expressions
- avoid_catches_without_on_clauses
- avoid_catching_errors
- avoid_classes_with_only_static_members
- avoid_double_and_int_checks
- avoid_empty_else
- avoid_equals_and_hash_code_on_mutable_classes
- avoid_escaping_inner_quotes
- avoid_field_initializers_in_const_classes
- avoid_function_literals_in_foreach_calls
- avoid_implementing_value_types
- avoid_init_to_null
- avoid_js_rounded_ints
- avoid_null_checks_in_equality_operators
- avoid_positional_boolean_parameters
- avoid_print
- avoid_private_typedef_functions
- avoid_redundant_argument_values
- avoid_relative_lib_imports
- avoid_renaming_method_parameters
- avoid_return_types_on_setters
- avoid_returning_null
- avoid_returning_null_for_future
- avoid_returning_null_for_void
- avoid_returning_this
- avoid_setters_without_getters
- avoid_shadowing_type_parameters
- avoid_single_cascade_in_expression_statements
- avoid_slow_async_io
- avoid_type_to_string
- avoid_types_as_parameter_names
- avoid_types_on_closure_parameters
- avoid_unnecessary_containers
- avoid_unused_constructor_parameters
- avoid_void_async
- avoid_web_libraries_in_flutter
- await_only_futures
- camel_case_extensions
- camel_case_types
- cancel_subscriptions
- cascade_invocations
- cast_nullable_to_non_nullable
- close_sinks
- comment_references
- constant_identifier_names
- control_flow_in_finally
- curly_braces_in_flow_control_structures
- diagnostic_describe_all_properties
- directives_ordering
- do_not_use_environment
- empty_catches
- empty_constructor_bodies
- empty_statements
- exhaustive_cases
- file_names
- flutter_style_todos
- hash_and_equals
- implementation_imports
- invariant_booleans
- iterable_contains_unrelated_type
- join_return_with_assignment
- leading_newlines_in_multiline_strings
- library_names
- library_prefixes
- lines_longer_than_80_chars
- list_remove_unrelated_type
- literal_only_boolean_expressions
- missing_whitespace_between_adjacent_strings
- no_adjacent_strings_in_list
- no_default_cases
- no_duplicate_case_values
- no_logic_in_create_state
- no_runtimeType_toString
- non_constant_identifier_names
- null_check_on_nullable_type_parameter
- null_closures
- omit_local_variable_types
- one_member_abstracts
- only_throw_errors
- overridden_fields
- package_api_docs
- package_names
- package_prefixed_library_names
- parameter_assignments
- prefer_adjacent_string_concatenation
- prefer_asserts_in_initializer_lists
- prefer_asserts_with_message
- prefer_collection_literals
- prefer_conditional_assignment
- prefer_const_constructors
- prefer_const_constructors_in_immutables
- prefer_const_declarations
- prefer_const_literals_to_create_immutables
- prefer_constructors_over_static_methods
- prefer_contains
- prefer_double_quotes
- prefer_equal_for_default_values
- prefer_expression_function_bodies
- prefer_final_fields
- prefer_final_in_for_each
- prefer_final_locals
- prefer_for_elements_to_map_fromIterable
- prefer_foreach
- prefer_function_declarations_over_variables
- prefer_generic_function_type_aliases
- prefer_if_elements_to_conditional_expressions
- prefer_if_null_operators
- prefer_initializing_formals
- prefer_inlined_adds
- prefer_int_literals
- prefer_interpolation_to_compose_strings
- prefer_is_empty
- prefer_is_not_empty
- prefer_is_not_operator
- prefer_iterable_whereType
- prefer_mixin
- prefer_null_aware_operators
- prefer_relative_imports
- prefer_single_quotes
- prefer_spread_collections
- prefer_typing_uninitialized_variables
- prefer_void_to_null
- provide_deprecation_message
- public_member_api_docs
- recursive_getters
- sized_box_for_whitespace
- slash_for_doc_comments
- sort_child_properties_last
- sort_constructors_first
- sort_pub_dependencies
- sort_unnamed_constructors_first
- test_types_in_equals
- throw_in_finally
- tighten_type_of_initializing_formals
- type_annotate_public_apis
- type_init_formals
- unawaited_futures
- unnecessary_await_in_return
- unnecessary_brace_in_string_interps
- unnecessary_const
- unnecessary_final
- unnecessary_getters_setters
- unnecessary_lambdas
- unnecessary_new
- unnecessary_null_aware_assignments
- unnecessary_null_checks
- unnecessary_null_in_if_null_operators
- unnecessary_nullable_for_final_variable_declarations
- unnecessary_overrides
- unnecessary_parenthesis
- unnecessary_raw_strings
- unnecessary_statements
- unnecessary_string_escapes
- unnecessary_string_interpolations
- unnecessary_this
- unrelated_type_equality_checks
- unsafe_html
- use_full_hex_values_for_flutter_colors
- use_function_type_syntax_for_parameters
- use_is_even_rather_than_modulo
- use_key_in_widget_constructors
- use_late_for_private_fields_and_variables
- use_raw_strings
- use_rethrow_when_possible
- use_setters_to_change_properties
- use_string_buffers
- use_to_and_as_if_applicable
- valid_regexps
- void_checks
141 changes: 141 additions & 0 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,141 @@
# Enable all rules by default
include: all_lint_rules.yaml
analyzer:
strong-mode:
implicit-casts: false
implicit-dynamic: false
errors:
dead_code: warning
# Otherwise cause the import of all_lint_rules to warn because of some rules conflicts.
# The conflicts are fixed in this file instead, so we can safely ignore the warning.
included_file_warning: ignore
missing_required_param: error
missing_return: error
enable-experiment:
- non-nullable

linter:
rules:
# We prefer having parameters in the same order as fields https://github.com/flutter/flutter/issues/10219
always_put_required_named_parameters_first: false

# Depends on your needs
always_require_non_null_named_parameters: false

# Conflicts with `omit_local_variable_types` and other rules.
# As per Dart guidelines, we want to avoid unnecessary types to make the code
# more readable.
# See https://dart.dev/guides/language/effective-dart/design#avoid-type-annotating-initialized-local-variables
always_specify_types: false

# conflicts with `prefer_relative_imports`
always_use_package_imports: false

# Conflicts with always_specify_types
avoid_annotating_with_dynamic: false

# There are situations where we voluntarily want to catch everything,
# especially as a library.
avoid_catches_without_on_clauses: false

# Only useful when targeting JS runtime
avoid_double_and_int_checks: false

# Improve readbility
avoid_function_literals_in_foreach_calls: false

# Only useful when targeting JS runtime
avoid_js_rounded_ints: false

# We prefer having typedef (discussion in https://github.com/flutter/flutter/pull/16356)
avoid_private_typedef_functions: false

# Useful in a lot of cases
avoid_returning_null: false

# Can be useful to have a more readable code
avoid_types_on_closure_parameters: false

# `as` is not that bad (especially with the upcoming non-nullable types).
# Explicit exceptions is better than implicit exceptions.
avoid_as: false

# Can be difficult to read in some cases
cascade_invocations: false

# Not reliable enough
close_sinks: false

# Blocked on https://github.com/flutter/flutter/issues/20765
comment_references: false

# Not useful for public properties for a constructor
diagnostic_describe_all_properties: false

# This project doesn't use Flutter-style todos
flutter_style_todos: false

# Experimental: Too many false positives: https://github.com/dart-lang/linter/issues/811
invariant_booleans: false

# Can be useful to have a more readable code
join_return_with_assignment: false

# Not useful for comments
lines_longer_than_80_chars: false

# Too many false positives: https://github.com/dart-lang/sdk/issues/34181
literal_only_boolean_expressions: false

# Disabled for now until we have NNBD as it otherwise conflicts with `missing_return`
no_default_cases: false

# Can be useful to have a more readable code
omit_local_variable_types: false

# Too many false positives
one_member_abstracts: false

# Issue: https://github.com/flutter/flutter/issues/5792
only_throw_errors: false

# Issue: https://github.com/dart-lang/language/issues/32
prefer_mixin: false

# Intelissence do the jobs for constructors.
prefer_asserts_with_message: false

# More readable
prefer_relative_imports: false

# Conflicts with `prefer_single_quotes`
# Single quotes are easier to type and don't compromise on readability.
prefer_double_quotes: false

# Conflicts with https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#consider-using--for-short-functions-and-methods
# Not quite suitable for Flutter, which may have a `build` method with a single
# return, but that return is still complex enough that a "body" is worth it.
prefer_expression_function_bodies: false

# False positives
top_level_function_literal_block: false

# We don't want to enforce this rule now.
sort_pub_dependencies: false

# Too many false positives
unawaited_futures: false

# Has false positives: https://github.com/dart-lang/linter/issues/498
unnecessary_lambdas: false

# Has false positives: https://github.com/dart-lang/sdk/issues/34182
use_string_buffers: false

# Has false positives, so we prefer to catch this by code-review
use_to_and_as_if_applicable: false

# Incompatible with `prefer_final_locals`
# Having immutable local variables makes larger functions more predictible
# so we will use `prefer_final_locals` instead.
unnecessary_final: false
2 changes: 1 addition & 1 deletion example/lib/main_34.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class Data {
void main() => runApp(MyApp());

Future<Data> getData() async {
await Future.delayed(Duration(seconds: 1));
await Future<void>.delayed(const Duration(seconds: 1));
return Data();
}

Expand Down
Loading

0 comments on commit 31bb071

Please sign in to comment.