fix: support finding ssh process by port on macos sequoia #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanndickson
force-pushed
the
ethan/fix-conn-indicator-sequoia
branch
from
7b1eda3 to
facb2eb
Compare
ethanndickson
force-pushed
the
ethan/fix-conn-indicator-sequoia
branch
from
86f3458 to
f6c1272
Compare
code-asher
approved these changes
Apr 15, 2025
|
Will need someone else to merge, as I don't have permission! |
This is becoming more than a want now, and we may actually need this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #361.
This brings back the connection indicator, at least on macOS Sequoia.
The indicator is populated from a file named
<sshPID>.json. The library we were using to find that PID,find-processhasn't been updated for Sequoia.Full explanation of the necessary change can be found in an umerged PR for that library:
yibn2008/find-process#78
This change was never merged, so I've forked it into our org for now. When it gets upstreamed we can switch back.