prevent unintended early return from skipping writing wildcard configs

[bcpeinhardt]

If a user didn't have a jetbrain's plugin block in their ssh config, we accidentally skipped writing one because before wildcards not having any listed workspaces was equivalent to not having anything to write into the config. This fixes that by checking specifically if the contents of the block are empty.

fixes #534

[github-actions]

Qodana Community for JVM

6 new problems were found

Inspection name	Severity	Problems
Incorrect string capitalization	🔶 Warning	1
Redundant nullable return type	🔶 Warning	1
String concatenation that can be converted to string template	◽️ Notice	2
Class member can have 'private' visibility	◽️ Notice	1
Redundant lambda arrow	◽️ Notice	1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

1. Register at Qodana Cloud and configure the action
2. Use GitHub Code Scanning with Qodana
3. Host Qodana report at GitHub Pages
4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[aaronlehmann]

Thanks for fixing this!

[rtorrente]

Hello all,

Am I the only one for whom SSH configuration still doesn't seem to write and I still get the same error? I always have the same error in log

I'm on version 2.18.1 on MacOS.

2025-02-22 22:05:18,968 [2617654]   INFO - CoderCLIManager - Configuring SSH config at /Users/xxxx/.ssh/config
2025-02-22 22:05:18,969 [2617655]   INFO - CoderCLIManager - No workspaces and no existing config blocks to remove
2025-02-22 22:05:18,969 [2617655]   INFO - CoderWorkspaceProjectIDEStepView - Connecting with SSH and uploading worker if missing... (attempt 1)
2025-02-22 22:05:18,970 [2617656]   INFO - CoderSettings - Resolving binary for MAC ARM64
2025-02-22 22:05:18,970 [2617656]   INFO - CoderSettings - Resolving binary for MAC ARM64
2025-02-22 22:05:18,988 [2617674]   INFO - CoderCLIManager - `/Users/xxxx/Library/Application Support/coder-gateway/xxxxxxxx/coder-darwin-arm64 version --output json`: {
  "version": "v2.19.0+2f32b11",
  "build_time": "2025-02-04T07:53:51Z",
  "external_url": "https://github.com/coder/coder/commit/2f32b11831a236ed550f35b2296b8f948eb64f4e",
  "slim": true,
  "agpl": false,
  "boring_crypto": false
}

2025-02-22 22:05:18,988 [2617674]   INFO - net.schmizz.sshj.transport.random.JCERandom - Creating new SecureRandom.
2025-02-22 22:05:19,082 [2617768]   WARN - #c.i.s.i.s.sshj - Failed to connect. Brief info: SSH connection to [email protected]:22
 * With altered connection settings:
  - authMethods: PublicKey(privateKeys=[/Users/xxxx/.ssh/id_rsa, /Users/xxxx/.ssh/id_ecdsa, /Users/xxxx/.ssh/id_ecdsa_sk, /Users/xxxx/.ssh/id_ed25519, /Users/xxxx/.ssh/id_ed25519_sk, /Users/xxxx/.ssh/id_xmss, /Users/xxxxx/.ssh/id_dsa], agent=ALL), Password, KeyboardInteractive
  - ciphers: [[email protected], aes128-ctr, aes192-ctr, aes256-ctr, [email protected], [email protected]]
  - environmentVariables: [Inherit(glob=LANG), Inherit(glob=LC_*)]
  - hostKeyAlgorithms: [[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], ssh-ed25519, ecdsa-sha2-nistp256, ecdsa-sha2-nistp384, ecdsa-sha2-nistp521, [email protected], [email protected], rsa-sha2-512, rsa-sha2-256]
  - hostKeyVerifier: OpenSSH-like host key verifier (knownHostsFile=[/Users/xxx/.ssh/known_hosts, /Users/xxxxxx/.ssh/known_hosts2, /private/etc/ssh/ssh_known_hosts, /private/etc/ssh/ssh_known_hosts2], strictHostKeyChecking=ASK, hashKnownHosts=false)
  - kexAlgorithms: [[email protected], curve25519-sha256, [email protected], ecdh-sha2-nistp256, ecdh-sha2-nistp384, ecdh-sha2-nistp521, diffie-hellman-group-exchange-sha256, diffie-hellman-group16-sha512, diffie-hellman-group18-sha512, diffie-hellman-group14-sha256]
  - macs: [[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], hmac-sha2-256, hmac-sha2-512, hmac-sha1]
  - user: coder
 * With auth agent ssh-agent[/private/tmp/com.apple.launchd.OE9ZLgkVBb/Listeners]
java.net.UnknownHostException: coder-jetbrains-coder.xxxxxxxx.dev
	at java.base/java.net.InetAddress$CachedLookup.get(InetAddress.java:988)
	at java.base/java.net.InetAddress.getAllByName0(InetAddress.java:1818)
	at java.base/java.net.InetAddress.getAllByName(InetAddress.java:1688)
	at com.intellij.ssh.impl.sshj.SshjConnectionUtilKt.connectPlatform(SshjConnectionUtil.kt:854)
	at com.intellij.ssh.impl.sshj.SshjConnectionUtilKt.setUpSessionForSshJ$lambda$13(SshjConnectionUtil.kt:222)
	at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804)
	at com.intellij.util.concurrency.ChildContext$runInChildContext$1.invoke(propagation.kt:103)
	at com.intellij.util.concurrency.ChildContext$runInChildContext$1.invoke(propagation.kt:103)
	at com.intellij.util.concurrency.ChildContext.runInChildContext(propagation.kt:109)
	at com.intellij.util.concurrency.ChildContext.runInChildContext(propagation.kt:103)
	at com.intellij.util.concurrency.ContextRunnable.run(ContextRunnable.java:27)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:735)
	at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:732)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1.run(Executors.java:732)
	at java.base/java.lang.Thread.run(Thread.java:1583)

[code-asher]

@rtorrente sorry for the delayed reply. The fix is in 2.19.0 I believe, so you may just need to update.