[WIP ]Toolbox ramp up #532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- toolbox can't load the plugin because of serialization issues. - backgroundColors is no longer recognized
- include latest 2.6.0 builds
Qodana Community for JVM16 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: trueContact Qodana teamContact us at [email protected]
|
- needed to build plugins for toolbox 2.6.0
- removed gateway api's no longer available in Toolbox 2.6.0 - replaced it with a couple of new toolbox api libraries
- removed gateway api's no longer available in Toolbox 2.6.0 - replaced it with a couple of new toolbox api libraries
- updated KSP to match Kotlin version - removed unused dependencies
- to reflect the new toolbox api
|
@fioan89 hello! |
|
Sure, sorry about that. |
|
Don't be! I'm communicating it for the first time now 💀 |
- to reflect the new toolbox api
- like core-api, ui-api, remote-dev-api which should no longer be packaged.
- okhttp is no longer provided by Toolbox - with this commit we package our own libraries
- slf4j runtime is no longer provided by Toolbox - the sample code promotes the usage of service locator to resolve a logger. However, this approach has a couple of downsides, mainly it tightly couples all layers of code because the service locator needs to be propagated from the dev extension down to the lowest level of coder business implementation. - instead, we now pack tinylog with slf4j bindings to avoid classloading issues.
- quality of life improvement to automate some recurring manual tasks like cleaning up the plugin install dir
- without the need to go through a "field accessor" - fixes some NPE when reading the url
fioan89
added a commit
to coder/coder-jetbrains-toolbox
that referenced
this pull request
Feb 24, 2025
Initial skeleton for Coder integration with JetBrains Toolbox - the code is imported from coder/jetbrains-coder - coder/jetbrains-coder#532 can provide a better view on the major changes compared with gateway
bcpeinhardt
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Sorry for the delay on getting to this. I'm going to try and free up more time this week to collaborate @fioan89
|
no worries. This is a stale PR, I think I'll close it. Most of the action now happens at https://github.com/coder/coder-jetbrains-toolbox-plugin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress to make the plugin load in the latest Toolbox versions (2.6.0).