Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wildcard SSH config Host entries #521

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

aaronlehmann
Copy link
Contributor

This simplifies the written SSH config and avoids the need to make an API request for every workspace the filter returns. This can remove minutes from the "Configuring Coder CLI..." step when the user has access to many workspaces (for example, an admin who wants the option of connecting to anyone's workspace on a large deployment).

Depends on coder/coder#16088

@aaronlehmann
Copy link
Contributor Author

cc @code-asher

@aaronlehmann aaronlehmann changed the title Use wildcard SSH config Host entries [WIP] Use wildcard SSH config Host entries Jan 10, 2025
@aaronlehmann aaronlehmann marked this pull request as draft January 10, 2025 03:44
@bcpeinhardt
Copy link
Collaborator

Looks good so far 😎

This simplifies the written SSH config and avoids the need to make an
API request for every workspace the filter returns. This can remove
minutes from the "Configuring Coder CLI..." step when the user has
access to many workspaces (for example, an admin who wants the option of
connecting to anyone's workspace on a large deployment).

Depends on coder/coder#16088
@aaronlehmann
Copy link
Contributor Author

I think this is ready for review. The Coder CLI version number placeholder just needs to be filled in when that release happens.

@aaronlehmann aaronlehmann changed the title [WIP] Use wildcard SSH config Host entries Use wildcard SSH config Host entries Feb 4, 2025
@aaronlehmann aaronlehmann marked this pull request as ready for review February 4, 2025 17:30
@aaronlehmann
Copy link
Contributor Author

The necessary changes were released in Coder 2.19.0, so this is ready to go now.

@@ -4,6 +4,10 @@

## Unreleased

### Changed

- Simplifies the written SSH config and avoids the need to make an API request for every workspace the filter returns.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcpeinhardt bcpeinhardt merged commit f39e1f4 into coder:main Feb 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants