revise recent projects flow to be less confusing #464
Conversation
Qodana Community for JVM4 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: trueContact Qodana teamContact us at [email protected]
|
| }.topGap(gap) | ||
| if (deploymentError == null || showError) { |
There was a problem hiding this comment.
I think we might want to add this check back or something similar to it. It is poorly named but basically it was making sure we only display an API error on the first workspace rather than duplicating it on each workspace (it was pretty noisy, especially since the API errors can get long).
For example, say you have 5 workspaces and your token expires, you see a message about being unauthorized and to check your token 5 times on the page.
Or we could group workspaces under a deployment heading and show the API error under the deployment heading, but that might be out of scope for this PR.
There was a problem hiding this comment.
It looks like atm the moment I actually have this inside the connections.foEach loop (which makes me think with multiple WorkpaceProjectIDE combos it would render multiple times). I didn't notice because I was visually testing with one recent connection.
I'll pull it out of the loop and add the check.
^^^ My adhd is going to quickly become a driving force for building out E2E suites.
| if (inLoadingState) { | ||
| icon(AnimatedIcon.Default()) | ||
| } |
There was a problem hiding this comment.
Not at all a blocker and completely optional, more just idly musing, but I wonder if we want to turn the pair back into a triple and put a nullable icon in there, which would let us also show a spinner while the query is running as well (like it used to) and bring back the error icon for API errors (if we want, honestly the red color is probably sufficient).
There was a problem hiding this comment.
I think adding the error icon back is a good idea and fits in this PR :)
| if (listOf(WorkspaceStatus.STOPPED, WorkspaceStatus.CANCELED, WorkspaceStatus.FAILED).contains(workspace.latestBuild.status)) { | ||
| client.startWorkspace(workspace) |
There was a problem hiding this comment.
I opened #465 for future improvement
|
Oh forgot, we should also update the changelog and make sure we describe when the links are enabled and that the manual controls are replaced in favor of automatically starting the workspace. |
|
resolves #436 |
| if (status.third != null) { | ||
| icon(status.third!!) | ||
| } |
There was a problem hiding this comment.
idk if this is more Kotlin-y but I think you can also do something like this over the assertion:
status.third?.let { icon (it) }
Admittedly untested though
There was a problem hiding this comment.
I low key hate that they named a function let 💀 TBH I think the assertion here is clearer, but if that's the kotlin way then I'm game haha. I could also do a withoutNull I suppose.
There was a problem hiding this comment.
withoutNull throws if null but here we are OK with the status potentially being null, so I think it would not quite fit here.
I think the main issue with assertions is that they bypass the safety provided to you by the language, which feels dangerous for an unclear benefit.
If you see a !! you need to reason about the entire code and determine that status.third is not going to be reassigned (and you need to do this every time related code is refactored), but we should let the machine do it for us. 😆 Admittedly it is pretty trivial in this case, but still!
There was a problem hiding this comment.
Yeah I meant use withoutNull inside the if check, but you're totally right the let method is the best option here, I just wish they called it somewhere else lol.
There was a problem hiding this comment.
ahaha yeah and I swear I have to look it up every time because I always forget it is called let
src/main/kotlin/com/coder/gateway/views/CoderGatewayRecentWorkspaceConnectionsView.kt
Outdated
Show resolved
Hide resolved
bcpeinhardt
deleted the
bcpeinhardt/436-add-labels-to-workspace-actions
branch
Edit: we changed the flow, links do show but are disabled if the workspace is in a non-starting pending state, and we started the workspace automatically negating the need to even have the manual controls
Previously recent workspaces had a status icon which looked a bit like a button to push, and the start workspace button could be confused as the cta to open a project.
Now the project links in recent projects only display once the workspace is running and ready to accept connections, and the confusing icon has been removed.
I think this flow is pretty clear, but people used to just clicking the link might freak out when they don't see their links or be frustrated they need to press two buttons.
An alternative option could be to remove the workspace start button entirely, since following a project link should start the workspace if required.
Screen.Recording.2024-08-14.at.12.06.40.PM.mov
resolves #436
EDIT:
We went down a rabbithole and reworked the recents page to be more consistent with the VSCode extension. There are no longer indpendent workspace controls on the recents page. You simply click the link and it handles the workspace lifecycle for you.