Use unique socket path per user.

coder · Jun 20, 2023 · f8c030d · f8c030d
1 parent 26c1bdd
commit f8c030d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/node/vscodeSocket.ts b/src/node/vscodeSocket.ts
@@ -8,7 +8,7 @@ import { listen } from "./app"
 import { canConnect } from "./util"
 
 // Socket path of the daemonized code-server instance.
-export const DEFAULT_SOCKET_PATH = path.join(os.tmpdir(), "code-server-ipc.sock")
+export const DEFAULT_SOCKET_PATH = path.join(os.tmpdir(), `code-server-ipc-${os.userInfo().username}.sock`)
 
 export interface EditorSessionEntry {
   workspace: {

diff --git a/test/unit/node/vscodeSocket.test.ts b/test/unit/node/vscodeSocket.test.ts
@@ -1,8 +1,18 @@
 import { logger } from "@coder/logger"
+import * as os from "os"
 import * as app from "../../../src/node/app"
-import { EditorSessionManager, makeEditorSessionManagerServer } from "../../../src/node/vscodeSocket"
+import {
+  DEFAULT_SOCKET_PATH,
+  EditorSessionManager,
+  makeEditorSessionManagerServer,
+} from "../../../src/node/vscodeSocket"
 import { clean, tmpdir, listenOn, mockLogger } from "../../utils/helpers"
 
+describe("DEFAULT_SOCKET_PATH", () => {
+  it("should be a unique path per user", () => {
+    expect(DEFAULT_SOCKET_PATH).toBe(`${os.tmpdir()}/code-server-ipc-${os.userInfo().username}.sock`)
+  })
+})
 describe("makeEditorSessionManagerServer", () => {
   let tmpDirPath: string