Feature/refactor #52
Open
Feature/refactor #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix missing character encoding and html lang tag. Refactor code structure and missplaced elements. Change script source for session.js to run locally.
Massive refactor to polish the code removing unused bits, changing `var` for `let`, fixing insecure http protocol for https and fixing architecture module that was broken because of a missnamed variable. Rename cookie to a more significative name: `session-js`.
This property allows to track the session from external libs or a backend. Once set, it will be written to the session and kept in the cookie.
Create a switch named extra that when set records extra client information. It was added from the demo page.
|
This looks good to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several changes to the library:
varforlet, fixing insecure http protocol for https and fixing architecture module that was broken because of a missnamed variable. Rename cookie to a more significative name:session-js.