[FYST-902] Add az 1099r to final review #5639
Open
+76
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hugo Melo <[email protected]>
|
Heroku app: https://gyr-review-app-5639-411eafa06a67.herokuapp.com/ |
Co-authored-by: Hugo Melo <[email protected]>
arinchoi03
reviewed
Feb 25, 2025
|
|
||
| <div class="spacing-below-5"> | ||
| <ul class="list--bulleted"> | ||
| <% current_intake.state_file1099_rs.each do |ten_ninety_nine_r| %> |
There was a problem hiding this comment.
can we name this state_file1099_r here? I feel like it's easier to read and consistent with other parts of the code
| @@ -200,3 +200,5 @@ | |||
|
|
|||
| <%= render "state_file/questions/shared/review_footer" %> | |||
| <% end %> | |||
|
|
|||
|
|
|||
| @@ -3,6 +3,7 @@ module Questions | |||
| class AzReviewController < BaseReviewController | |||
| def edit | |||
| @show_dependent_months_in_home = true | |||
| @show_retirement_income_deductions = true | |||
There was a problem hiding this comment.
why do we need this variable? If it's b/c we don't have a partial yet for the other 1099R deductions we could do something like:
<%= render :partial => "#{dynamic_partial}" rescue nil %>
See:
# app/views/state_file/questions/submission_confirmation/edit.html.erb
<%= render partial: "state_file/questions/submission_confirmation/#{current_state_code}_additional_content" rescue nil %>
| @@ -103,7 +103,7 @@ en: | |||
| edit: | |||
| info: | |||
| - File taxes online on your own using our partner website. This is our quickest option for households earning under $84,000 to file taxes and collect the tax credits you are owed! | |||
| - To get started, we’ll need to collect some basic information. | |||
| - To get started, we'll need to collect some basic information. | |||
There was a problem hiding this comment.
was this a deliberate change? I know we sometimes try to enforce one type of apostrophes vs another.
| @@ -651,7 +651,7 @@ en: | |||
| 01_hi: Hi %{first_name}, | |||
| 02_this_is_gyr: This is GetYourRefund. Thank you for choosing our free %{diy_link} option! Need help while completing your return? See our %{guide_link} for step-by-step instructions, tips, and best practices. | |||
| 03_if_you_get_stuck: If you get stuck or have a question, chat with us %{chat_with_us_link} or email us at %{email_us_link}. | |||
| 04_we_re_here_to_help: We’re here to help, | |||
| 04_we_re_here_to_help: We're here to help, | |||
| title: "Arizona retirement income deductions" | ||
| uniformed_services: "Retired or retainer pay of the uniformed services of the United States" | ||
| government_pension: "Qualifying federal, Arizona, or local government pension plan" | ||
| none_apply: "None apply" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
https://codeforamerica.atlassian.net/browse/FYST-902
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
How to test?
Screenshots (for visual changes)