Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fyst 1809 remove ip address #5637

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

DrewProebstel
Copy link
Contributor

@DrewProebstel DrewProebstel commented Feb 25, 2025

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Refactors PYA to allow sessions to be tracked via email in session rather than ip
  • bounces requests without sessions to verification error path
  • moves the #is_intake_locked tests to an example case
  • adds a rake file to populate fake addresses on existing StateFileArchivedIntakes

How to test?

  • A through testing of the PYA flow insuring lockouts happen
  • Specify any relevant testing environments used (e.g., development, staging, demo, Heroku).
  • Risk Assessment
    • The prod "get_your_pdf" flag will need to be turned off before we merge while we run the rake task to add addresses to the existing StateFileArchivedIntakes

Copy link

Heroku app: https://gyr-review-app-5637-5ead95104aa5.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5637 (optionally add --tail)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant