Fyst 1798 use df json data for mfj ssa income #5636
Conversation
|
Heroku app: https://gyr-review-app-5636-aa6902403ed4.herokuapp.com/ |
| @@ -112,6 +110,9 @@ | |||
| # | |||
| class StateFileMdIntake < StateFileBaseIntake | |||
| include MdResidenceCountyConcern | |||
|
|
|||
| self.ignored_columns += %w[primary_ssb_amount spouse_ssb_amount] | |||
There was a problem hiding this comment.
[q] this is data that clients self-reported. we can't really "backfill" this data back into the json files, so do we just keep it forever indefinitely? Or is it really fine to drop these columns?
| private | ||
|
|
||
| def social_security_benefit_amount_for(filer) | ||
| social_security_reports.filter { |social_security_report| social_security_report.recipient_tin == filer.tin }.sum(&:net_benefits) |
There was a problem hiding this comment.
sorry this is on my mind, but is there any likelihood at all we could get a null for the net_benefits amount?
| if @intake.filing_status_mfj? && @intake.direct_file_data.fed_ssb.positive? && @intake.spouse_ssb_amount.present? | ||
| @intake.spouse_ssb_amount.round | ||
| if @intake.filing_status_mfj? && @intake.direct_file_data.fed_ssb.positive? | ||
| @intake.direct_file_json_data.spouse_filer_social_security_benefit_amount&.round |
There was a problem hiding this comment.
[dust] just noticing that calculate_line_9a returns 0 if the amount is nilbutcalculate_line_9breturnsnilif it's nil, probably should choose one or the other, although it'll end up in the same place since this ultimately usesadd_element_if_present`
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
state_file_md_intakesHow to test?
socialSecurityReportsin their DF JSON. Verify that the output XML & PDF have the correct social security benefit amounts for the primary and spouse filers.